Skip to content

Commit 66297e1

Browse files
authored
fix: change the location of definition of type related configurations (#49)
## Proposed changes Reduce the risk of divergence between Type definition and actual implementation ## Types of changes [//]: # 'What types of changes does your code introduce to WebdriverIO?' [//]: # '_Put an `x` in the boxes that apply_' - [X] Polish (an improvement for an existing feature) - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improvements to the project's docs) - [ ] Internal updates (everything related to internal scripts, governance documentation and CI files) ## Checklist [//]: # "_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._" - [X] I have read the [CONTRIBUTING](https://github.com/webdriverio/vscode-webdriverio/blob/main/CONTRIBUTION.md) doc - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added the necessary documentation (if appropriate) - [ ] I have added proper type definitions for new commands (if appropriate) ## Further comments [//]: # 'If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...' ### Reviewers: @webdriverio/project-committers
1 parent f33af04 commit 66297e1

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

packages/vscode-wdio-constants/src/index.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,14 @@
11
/* c8 ignore start */
2+
export interface WebdriverIOConfig {
3+
nodeExecutable: string | undefined
4+
configFilePattern: string[]
5+
showOutput: boolean
6+
logLevel: string
7+
}
8+
29
export const EXTENSION_ID = 'webdriverio'
310

4-
export const DEFAULT_CONFIG_VALUES = {
11+
export const DEFAULT_CONFIG_VALUES: WebdriverIOConfig = {
512
nodeExecutable: undefined,
613
configFilePattern: ['**/*wdio*.conf*.{ts,js,mjs,cjs,cts,mts}'],
714
showOutput: true,

packages/vscode-wdio-types/src/utils.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
import type { LOG_LEVEL } from '@vscode-wdio/constants'
2-
3-
export interface WebdriverIOConfig {
4-
nodeExecutable: string | undefined
5-
configFilePattern: string[]
6-
showOutput: boolean
7-
logLevel: string
8-
}
2+
export type { WebdriverIOConfig } from '@vscode-wdio/constants'
93

104
export type WdioLogLevel = 'trace' | 'debug' | 'info' | 'warn' | 'error' | 'silent'
115

0 commit comments

Comments
 (0)