ci: window maximize on linux

Author: mato533

.github/workflows/actions/set-screen-resolution/action.yml

@@ -17,11 +17,18 @@ runs:
       run: |
         Set-DisplayResolution -Width ${{ inputs.width }} -Height ${{ inputs.height }} -Force
 
+    # I don't know the details, but it appears that it needs to be maximized at the Webdriver level
+    # because it does not launch in full screen on Linux.
+    # However, as the following Issue states, Electron(base of vscode) can not be muximize by webdriver protocol.
+    # https://github.com/electron/electron/issues/33942
+    # Therefore, GUI-based methods are used to maximize the screen.
+    # The process of maximizing screen size using xdotool is done in the before hook of wdio.conf.ts.
     - name: Set display resolution on Linux
       if: runner.os == 'Linux'
       shell: bash
       run: |
-        pnpm --filter @vscode-wdio/xvfb-patch run patch
+        pnpm --filter @vscode-wdio/xvfb-patch run patch -w ${{ inputs.width }} -h ${{ inputs.height }}
+        sudo apt install -y xdotool
 
     # already use FHD resolution
     - name: Set display resolution on MacOS

e2e/wdio.conf.ts

@@ -2,6 +2,7 @@ import * as path from 'node:path'
 import * as url from 'node:url'
 
 import { minVersion } from 'semver'
+import shell from 'shelljs'
 
 import pkg from '../packages/vscode-webdriverio/package.json' with { type: 'json' }
 import type { Frameworks } from '@wdio/types'
@@ -59,6 +60,9 @@ export function createBaseConfig(workspacePath: string, userSettings = {}): Webd
                     workspacePath: path.resolve(workspacePath),
                 },
                 'wdio:enforceWebDriverClassic': true,
+                'goog:chromeOptions': {
+                    args: ['window-size=1920,1080'],
+                },
             },
         ],
 
@@ -76,6 +80,14 @@ export function createBaseConfig(workspacePath: string, userSettings = {}): Webd
             timeout: 6000000,
             require: ['assertions/index.ts'],
         },
+        before: async function (_capabilities, _specs, _browser) {
+            if (process.platform === 'linux') {
+                const result = shell.exec('xdotool search --onlyvisible --name code')
+                const windowId = result.stdout.trim()
+                shell.exec(`xdotool windowmove ${windowId} 0 0`)
+                shell.exec(`xdotool windowsize ${windowId} 100% 100%`)
+            }
+        },
         afterTest: async function (_test: unknown, _context: unknown, _result: Frameworks.TestResult) {
             // if (!result.passed) {
             await browser.saveScreenshot(path.join(outputDir, `screenshot-${screenshotCount++}.png`))

infra/xvfb-patch/src/index.ts

@@ -1,16 +1,32 @@
 import * as fs from 'node:fs'
 import * as path from 'node:path'
 import { fileURLToPath } from 'node:url'
+import { parseArgs } from 'node:util'
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 const rootDir = path.resolve(__dirname, '../../..')
 const filePath = path.join(rootDir, 'node_modules', 'xvfb-maybe', 'src', 'xvfb-maybe.js')
 
-const width = 1920
-const height = 1920
+const args = process.argv.slice(2)
+const optionsDef = {
+    width: {
+        type: 'string',
+        short: 'w',
+    },
+    height: {
+        type: 'string',
+        short: 'h',
+    },
+} as const
+
+const { values: options } = parseArgs({ args, options: optionsDef })
+
+console.log('Adjust screen resolution')
+console.log(`  Width : ${options.width}`)
+console.log(`  Height: ${options.height}`)
 
 const insertBefore = "const dblDashPos = args.indexOf('--'),"
-const codeToInsert = `  args.unshift('--server-args="'-screen 0 ${width}x${height}x24'"', '--');`
+const codeToInsert = `  args.unshift('--server-args=-screen 0 ${options.width}x${options.height}x24', '--');`
 
 const sourceCode = fs.readFileSync(filePath, 'utf-8')
 
@@ -23,10 +39,10 @@ const lines = sourceCode.split('\n')
 const index = lines.findIndex((line) => line.includes(insertBefore))
 
 if (index !== -1) {
-    lines.splice(index, 0, codeToInsert) // 挿入
+    lines.splice(index, 0, codeToInsert)
     const newCode = lines.join('\n')
     fs.writeFileSync(filePath, newCode, 'utf-8')
-    console.log('✅ xvfb-maybe is patched successfully')
+    console.log('\n✅ xvfb-maybe is patched successfully')
 } else {
-    console.log('💥 could not find the target line.')
+    console.log('\n💥 could not find the target line.')
 }