Skip to content

Commit 7751c77

Browse files
committed
fix: always save images for save methods
1 parent 28e2f2e commit 7751c77

5 files changed

Lines changed: 15 additions & 5 deletions

File tree

packages/image-comparison-core/src/commands/saveAppElement.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ export default async function saveAppElement(
4141
tag,
4242
isNativeContext,
4343
instanceData: instanceData,
44-
wicOptions: saveElementOptions.wic
44+
// save* methods should always save files, regardless of alwaysSaveActualImage setting
45+
// (alwaysSaveActualImage only applies to check* methods)
46+
wicOptions: { ...saveElementOptions.wic, alwaysSaveActualImage: true }
4547
})
4648

4749
return afterScreenshot(browserInstance, afterOptions)

packages/image-comparison-core/src/commands/saveAppScreen.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ export default async function saveAppScreen(
5252
tag,
5353
isNativeContext,
5454
instanceData,
55-
wicOptions: saveScreenOptions.wic
55+
// save* methods should always save files, regardless of alwaysSaveActualImage setting
56+
// (alwaysSaveActualImage only applies to check* methods)
57+
wicOptions: { ...saveScreenOptions.wic, alwaysSaveActualImage: true }
5658
})
5759

5860
return afterScreenshot(browserInstance, afterOptions)

packages/image-comparison-core/src/commands/saveFullPageScreen.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ export default async function saveFullPageScreen(
8888
instanceData,
8989
enrichedInstanceData,
9090
beforeOptions,
91-
wicOptions: { formatImageName, savePerInstance, alwaysSaveActualImage: saveFullPageOptions.wic.alwaysSaveActualImage }
91+
// save* methods should always save files, regardless of alwaysSaveActualImage setting
92+
// (alwaysSaveActualImage only applies to check* methods)
93+
wicOptions: { formatImageName, savePerInstance, alwaysSaveActualImage: true }
9294
})
9395

9496
return afterScreenshot(browserInstance, afterOptions!)

packages/image-comparison-core/src/commands/saveWebElement.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,9 @@ export default async function saveWebElement(
8181
instanceData,
8282
enrichedInstanceData,
8383
beforeOptions,
84-
wicOptions: { formatImageName, savePerInstance, alwaysSaveActualImage: saveElementOptions.wic.alwaysSaveActualImage }
84+
// save* methods should always save files, regardless of alwaysSaveActualImage setting
85+
// (alwaysSaveActualImage only applies to check* methods)
86+
wicOptions: { formatImageName, savePerInstance, alwaysSaveActualImage: true }
8587
})
8688

8789
return afterScreenshot(browserInstance, afterOptions)

packages/image-comparison-core/src/commands/saveWebScreen.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,9 @@ export default async function saveWebScreen(
7676
instanceData,
7777
enrichedInstanceData,
7878
beforeOptions,
79-
wicOptions: { formatImageName, savePerInstance, alwaysSaveActualImage: saveScreenOptions.wic.alwaysSaveActualImage }
79+
// save* methods should always save files, regardless of alwaysSaveActualImage setting
80+
// (alwaysSaveActualImage only applies to check* methods)
81+
wicOptions: { formatImageName, savePerInstance, alwaysSaveActualImage: true }
8082
})
8183

8284
return afterScreenshot(browserInstance, afterOptions)

0 commit comments

Comments
 (0)