fix: fix issue 1085

- added tests

Author: wswebcreation

packages/image-comparison-core/src/methods/images.executeImageCompare.test.ts

@@ -665,6 +665,14 @@ describe('executeImageCompare', () => {
                 autoSaveBaseline: true,
             }
         }
+
+        vi.mocked(fsPromises.access).mockImplementation(async (path: any) => {
+            if (path === '/mock/baseline/test.png') {
+                throw new Error('File not found')
+            }
+            return undefined
+        })
+
         vi.mocked(compareImages.default).mockResolvedValue({
             rawMisMatchPercentage: 0,
             misMatchPercentage: 0,
@@ -1043,4 +1051,44 @@ describe('executeImageCompare', () => {
         expect(images.saveBase64Image).not.toHaveBeenCalled()
         expect(log.warn).not.toHaveBeenCalled()
     })
+
+    it('should not save actual image when autoSaveBaseline is true, alwaysSaveActualImage is false, baseline exists, and comparison passes', async () => {
+        // This test covers issue #1085: autoSaveBaseline collides with alwaysSaveActualImage
+        // When baseline exists and comparison passes, actual image should NOT be saved
+        const base64Image = Buffer.from('base64-image').toString('base64')
+        const optionsWithAutoSave = {
+            ...mockOptions,
+            folderOptions: {
+                ...mockOptions.folderOptions,
+                alwaysSaveActualImage: false,
+                autoSaveBaseline: true,
+            }
+        }
+
+        vi.mocked(fsPromises.access).mockResolvedValue(undefined)
+
+        vi.mocked(images.checkBaselineImageExists).mockImplementation(async () => {
+            return Promise.resolve()
+        })
+
+        vi.mocked(compareImages.default).mockResolvedValue({
+            rawMisMatchPercentage: 0,
+            misMatchPercentage: 0,
+            getBuffer: vi.fn().mockResolvedValue(Buffer.from('diff-image-data')),
+            diffBounds: { left: 0, top: 0, right: 0, bottom: 0 },
+            analysisTime: 10,
+            diffPixels: []
+        })
+
+        await executeImageCompare({
+            isViewPortScreenshot: true,
+            isNativeContext: false,
+            options: optionsWithAutoSave,
+            testContext: mockTestContext,
+            actualBase64Image: base64Image,
+        })
+
+        expect(images.saveBase64Image).not.toHaveBeenCalled()
+        expect(fsPromises.writeFile).not.toHaveBeenCalledWith('/mock/actual/test.png', expect.anything())
+    })
 })

packages/image-comparison-core/src/methods/images.ts

@@ -384,8 +384,8 @@ export async function executeImageCompare(
     if (useBase64Image) {
         // Convert base64 to buffer for comparison
         actualImageBuffer = Buffer.from(actualBase64Image, 'base64')
-        // Only save if autoSaveBaseline is true (needed to copy to baseline)
-        if (autoSaveBaseline) {
+        // Only save actual image if baseline doesn't exist and autoSaveBaseline is true
+        if (autoSaveBaseline && !(await checkIfImageExists(baselineFilePath))) {
             await saveBase64Image(actualBase64Image, actualFilePath)
         }
     } else {