Better unit tests

Author: dprevost-LMI

test/matchers/element/toBeDisplayed.test.ts

@@ -4,7 +4,7 @@ import { $ } from '@wdio/globals'
 import { toBeDisplayed } from '../../../src/matchers/element/toBeDisplayed.js'
 import { executeCommandBe } from '../../../src/utils.js'
 import { DEFAULT_OPTIONS, DEFAULT_OPTIONS_TO_BE_DISPLAYED } from '../../../src/constants.js'
-import { setOptions } from '../../../src/index.js'
+import { setDefaultOptions, setOptions } from '../../../src/index.js'
 import type { ChainablePromiseElement } from 'webdriverio'
 
 vi.mock('@wdio/globals')
@@ -198,24 +198,33 @@ Received: "not displayed"`
         let el: ChainablePromiseElement
 
         beforeEach(async () => {
-            // Set global options to custom values before each test
-            setOptions({ wait: 99, interval: 101 })
+            setDefaultOptions({ wait: 99, interval: 101 })
             el = await $('sel')
             el.isDisplayed = vi.fn().mockResolvedValue(true)
 
         })
 
         afterEach(() => {
-            // Reset options after each test to avoid side effects
-            setOptions(defaultOptions)
-            expect(DEFAULT_OPTIONS.wait).not.toBe(99)
+            setDefaultOptions(defaultOptions)
         })
 
-        test('should use globally set default options with executeCommandBe', async () => {
-            await toBeDisplayed.call({}, el)
+        test('should have legacy setOptions still work', () => {
+            setOptions({ wait: 102 })
+            expect(DEFAULT_OPTIONS.wait).toBe(102)
+            expect(DEFAULT_OPTIONS_TO_BE_DISPLAYED.wait).toBe(102)
+        })
 
+        test('should have affect all DEFAULT_OPTIONS_* options', () => {
             expect(DEFAULT_OPTIONS.wait).toBe(99)
+            expect(DEFAULT_OPTIONS.interval).toBe(101)
+
             expect(DEFAULT_OPTIONS_TO_BE_DISPLAYED.wait).toBe(99)
+            expect(DEFAULT_OPTIONS_TO_BE_DISPLAYED.interval).toBe(101)
+        })
+
+        test('should use globally set default options with executeCommandBe', async () => {
+            await toBeDisplayed.call({}, el)
+
             expect(executeCommandBe).toHaveBeenCalledWith(
                 el,
                 expect.anything(),