Better unit test

Author: dprevost-LMI

test/matchers/element/toBeDisplayed.test.ts

@@ -3,8 +3,8 @@ import { $ } from '@wdio/globals'
 
 import { toBeDisplayed } from '../../../src/matchers/element/toBeDisplayed.js'
 import { executeCommandBe } from '../../../src/utils.js'
-import { DEFAULT_OPTIONS, DEFAULT_OPTIONS_TO_BE_DISPLAYED } from '../../../src/constants.js'
-import { setOptions } from '../../../src/index.js'
+import { DEFAULT_OPTIONS } from '../../../src/constants.js'
+import { setDefaultOptions } from '../../../src/index.js'
 import type { ChainablePromiseElement } from 'webdriverio'
 
 vi.mock('@wdio/globals')
@@ -198,24 +198,19 @@ Received: "not displayed"`
         let el: ChainablePromiseElement
 
         beforeEach(async () => {
-            // Set global options to custom values before each test
-            setOptions({ wait: 99, interval: 101 })
+            setDefaultOptions({ wait: 99, interval: 101 })
             el = await $('sel')
             el.isDisplayed = vi.fn().mockResolvedValue(true)
 
         })
 
         afterEach(() => {
-            // Reset options after each test to avoid side effects
-            setOptions(defaultOptions)
-            expect(DEFAULT_OPTIONS.wait).not.toBe(99)
+            setDefaultOptions(defaultOptions)
         })
 
         test('should use globally set default options with executeCommandBe', async () => {
             await toBeDisplayed.call({}, el)
 
-            expect(DEFAULT_OPTIONS.wait).toBe(99)
-            expect(DEFAULT_OPTIONS_TO_BE_DISPLAYED.wait).toBe(99)
             expect(executeCommandBe).toHaveBeenCalledWith(
                 el,
                 expect.anything(),

test/options.test.ts

@@ -2,31 +2,36 @@ import { test, expect, describe, afterEach } from 'vitest'
 import { setDefaultOptions, setOptions } from '../src/index.js'
 import { DEFAULT_OPTIONS, DEFAULT_OPTIONS_TO_BE_DISPLAYED } from '../src/constants.js'
 
-describe('setDefaultOptions', () => {
+describe('Default Options', () => {
     const defaultOptions = { ...DEFAULT_OPTIONS }
     afterEach(() => {
-        // Reset global options to default values after each test
-        setOptions(defaultOptions)
+        setDefaultOptions(defaultOptions)
     })
 
-    test('setOptions should update both DEFAULT_OPTIONS_TO_BE_DISPLAYED and DEFAULT_OPTIONS', () => {
-        expect(DEFAULT_OPTIONS_TO_BE_DISPLAYED.wait).not.toBe(1234)
-        expect(DEFAULT_OPTIONS.wait).not.toBe(1234)
+    describe(setOptions, () => {
+        test('legacy setOptions should update both DEFAULT_OPTIONS_TO_BE_DISPLAYED and DEFAULT_OPTIONS', () => {
+            expect(DEFAULT_OPTIONS_TO_BE_DISPLAYED.wait).not.toBe(98)
+            expect(DEFAULT_OPTIONS.wait).not.toBe(98)
 
-        setOptions({ wait: 1234 })
+            setOptions({ wait: 98 })
 
-        expect(DEFAULT_OPTIONS_TO_BE_DISPLAYED.wait).toBe(1234)
-        expect(DEFAULT_OPTIONS.wait).toBe(1234)
+            expect(DEFAULT_OPTIONS_TO_BE_DISPLAYED.wait).toBe(98)
+            expect(DEFAULT_OPTIONS.wait).toBe(98)
+        })
     })
 
-    test('setDefaultOptions should update both DEFAULT_OPTIONS_TO_BE_DISPLAYED and DEFAULT_OPTIONS', () => {
-        expect(DEFAULT_OPTIONS_TO_BE_DISPLAYED.wait).not.toBe(1234)
-        expect(DEFAULT_OPTIONS.wait).not.toBe(1234)
+    describe(setDefaultOptions, () => {
 
-        setDefaultOptions({ wait: 1234 })
+        test('setDefaultOptions should update both DEFAULT_OPTIONS_TO_BE_DISPLAYED and DEFAULT_OPTIONS', () => {
+            expect(DEFAULT_OPTIONS_TO_BE_DISPLAYED.wait).not.toBe(1234)
+            expect(DEFAULT_OPTIONS.wait).not.toBe(1234)
 
-        expect(DEFAULT_OPTIONS_TO_BE_DISPLAYED.wait).toBe(1234)
-        expect(DEFAULT_OPTIONS.wait).toBe(1234)
+            setDefaultOptions({ wait: 1234 })
+
+            expect(DEFAULT_OPTIONS_TO_BE_DISPLAYED.wait).toBe(1234)
+            expect(DEFAULT_OPTIONS.wait).toBe(1234)
+        })
     })
+
 })