Skip to content

Commit e4b28ce

Browse files
committed
Code refactor
1 parent a7c68f7 commit e4b28ce

3 files changed

Lines changed: 22 additions & 42 deletions

File tree

packages/script/src/collectors/networkRequests.ts

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,5 @@
11
import type { Collector } from './collector.js'
2-
3-
export interface NetworkRequest {
4-
id: string
5-
url: string
6-
method: string
7-
status?: number
8-
statusText?: string
9-
type: string
10-
initiator?: string
11-
size?: number
12-
time?: number
13-
requestHeaders?: Record<string, string>
14-
responseHeaders?: Record<string, string>
15-
requestBody?: string
16-
responseBody?: string
17-
timestamp: number
18-
startTime: number
19-
endTime?: number
20-
error?: string
21-
}
2+
import type { NetworkRequest } from '../../types.js'
223

234
export class NetworkRequestCollector implements Collector<NetworkRequest> {
245
#requests: NetworkRequest[] = []

packages/script/types.d.ts

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,25 @@
11
import type { DataCollectorType } from './src/collector.ts'
22
import type { ConsoleLog as ConsoleLogImport } from './src/collectors/consoleLogs.ts'
3-
import type { NetworkRequest as NetworkRequestImport } from './src/collectors/networkRequests.ts'
3+
4+
export interface NetworkRequest {
5+
id: string
6+
url: string
7+
method: string
8+
status?: number
9+
statusText?: string
10+
type: string
11+
initiator?: string
12+
size?: number
13+
time?: number
14+
requestHeaders?: Record<string, string>
15+
responseHeaders?: Record<string, string>
16+
requestBody?: string
17+
responseBody?: string
18+
timestamp: number
19+
startTime: number
20+
endTime?: number
21+
error?: string
22+
}
423

524
export interface TraceMetadata {
625
url: string
@@ -16,7 +35,7 @@ export interface SimplifiedVNode {
1635

1736
declare global {
1837
type ConsoleLogs = ConsoleLogImport
19-
type NetworkRequest = NetworkRequestImport
38+
type NetworkRequest = NetworkRequest
2039

2140
interface Element {
2241
'wdio-ref': string

packages/service/src/types.ts

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -25,26 +25,6 @@ export interface Metadata {
2525
viewport: VisualViewport
2626
}
2727

28-
export interface NetworkRequest {
29-
id: string
30-
url: string
31-
method: string
32-
status?: number
33-
statusText?: string
34-
type: string
35-
initiator?: string
36-
size?: number
37-
time?: number
38-
requestHeaders?: Record<string, string>
39-
responseHeaders?: Record<string, string>
40-
requestBody?: string
41-
responseBody?: string
42-
timestamp: number
43-
startTime: number
44-
endTime?: number
45-
error?: string
46-
}
47-
4828
export interface TraceLog {
4929
mutations: TraceMutation[]
5030
logs: string[]

0 commit comments

Comments
 (0)