refactor(electron): address lint warnings

- Updated the `createBinaryPathResult` function to utilize a new `BinaryPathResultOptions` interface, enhancing type safety and clarity.
- Replaced deprecated `success` pattern with the `ok` pattern and adjusted the handling of binary paths and validation attempts.
- Ensured consistent usage of optional chaining and default values for better reliability in path generation and validation.

Author: goosewobbler

packages/electron-service/test/testHelpers.ts

@@ -1,31 +1,30 @@
-import type { BinaryPathResult } from '@wdio/native-types';
+import type { BinaryPathResult, PathValidationAttempt } from '@wdio/native-types';
 
-/**
- * Test helper to create properly typed BinaryPathResult mocks
- * Uses the new `ok` pattern instead of the deprecated `success` pattern
- */
-export function createBinaryPathResult(options: {
+interface BinaryPathResultOptions {
   success: boolean;
   binaryPath?: string;
   paths?: string[];
-  attempts?: Array<{ path: string; valid: boolean; error?: { type: string; message: string; code?: string } }>;
-}): BinaryPathResult {
+  attempts?: PathValidationAttempt[];
+}
+
+export function createBinaryPathResult(options: BinaryPathResultOptions): BinaryPathResult {
   if (options.success) {
+    const binaryPath = options.binaryPath ?? '';
     return {
       ok: true,
       value: {
-        binaryPath: options.binaryPath!,
+        binaryPath,
         pathGeneration: {
           ok: true,
           value: {
-            paths: options.paths || [options.binaryPath!],
+            paths: options.paths || [binaryPath],
           },
         },
         pathValidation: {
           ok: true,
           value: {
-            validPath: options.binaryPath!,
-            attempts: options.attempts || [{ path: options.binaryPath!, valid: true }],
+            validPath: binaryPath,
+            attempts: options.attempts || [{ path: binaryPath, valid: true }],
           },
         },
       },
@@ -36,7 +35,7 @@ export function createBinaryPathResult(options: {
     ok: false,
     error: {
       pathGeneration: {
-        ok: options.paths ? true : false,
+        ok: !!options.paths,
         value: options.paths ? { paths: options.paths } : undefined,
         error: !options.paths ? { errors: [{ type: 'CONFIG_INVALID', message: 'No paths generated' }] } : undefined,
       } as import('@wdio/native-types').PathGenerationResult,