Skip to content

Commit 3707b16

Browse files
goosewobblerclaude
andauthored
fix(ci): address releasekit integration issues (#239)
* fix(ci): address releasekit integration issues and improve release workflow - Add pull-requests: read permission to gate job (fixes silent label lookup failure that caused bump:patch + scope:spy to never trigger a release) - Add skip-checkout: 'true' to gate step (eliminates redundant double checkout) - Propagate gate-stable output so release:stable label graduates prereleases to stable instead of always publishing as prerelease - Honour inputs.target_packages in reusable workflow (removes redundant scope→package case statement that duplicated the scopeLabels config) Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * refactor(release): remove stable input from release workflows - Eliminated the `stable` input from both the reusable and main release workflows to streamline the release process. - Updated the logic to determine release type based solely on the `release_type` input, enhancing clarity and reducing complexity. * chore: upgrade @releasekit dependencies to version 0.17.1 - Updated `@releasekit/release`, `@releasekit/notes`, `@releasekit/publish`, and `@releasekit/version` to version `0.17.1` in `package.json` and `pnpm-lock.yaml` for improved functionality and bug fixes. - Modified GitHub workflows to utilize the latest version of ReleaseKit, ensuring consistency in the release process. --------- Co-authored-by: Claude Sonnet 4.6 <[email protected]>
1 parent f853239 commit 3707b16

5 files changed

Lines changed: 29 additions & 30 deletions

File tree

.github/workflows/_release.reusable.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@ on:
1616
description: 'Version increment (patch, minor, major)'
1717
required: true
1818
type: string
19-
stable:
20-
description: 'Graduate prerelease to stable without bumping'
21-
required: false
22-
type: string
23-
default: 'false'
2419
release_type:
2520
description: 'Release type (stable or prerelease)'
2621
required: false
@@ -230,11 +225,11 @@ jobs:
230225
231226
- name: Run ReleaseKit
232227
id: releasekit
233-
uses: goosewobbler/[email protected].0
228+
uses: goosewobbler/[email protected].1
234229
with:
235230
mode: release
236231
node-version: '24'
237-
target: ${{ steps.targets.outputs.packages }}
232+
target: ${{ inputs.target_packages || steps.targets.outputs.packages }}
238233
branch: ${{ inputs.target_branch }}
239234
bump: ${{ steps.params.outputs.bump }}
240235
stable: ${{ steps.params.outputs.stable }}

.github/workflows/release-preview.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
fetch-depth: 0
2828

2929
- name: Release Preview
30-
uses: goosewobbler/[email protected].0
30+
uses: goosewobbler/[email protected].1
3131
with:
3232
node-version: '24'
3333
mode: preview

.github/workflows/release.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,17 @@ jobs:
6161
gate:
6262
name: Gate
6363
runs-on: ubuntu-latest
64+
permissions:
65+
contents: read
66+
actions: read
67+
pull-requests: read
6468
if: github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.event == 'push'
6569
outputs:
6670
should_release: ${{ steps.gate.outputs.should-release }}
6771
bump: ${{ steps.gate.outputs.bump }}
6872
scope: ${{ steps.gate.outputs.gate-scope }}
6973
target: ${{ steps.gate.outputs.gate-target }}
74+
stable: ${{ steps.gate.outputs.gate-stable }}
7075
steps:
7176
- name: Checkout
7277
uses: actions/checkout@v6
@@ -75,14 +80,15 @@ jobs:
7580

7681
- name: Run ReleaseKit Gate
7782
id: gate
78-
uses: goosewobbler/[email protected].0
83+
uses: goosewobbler/[email protected].1
7984
with:
8085
mode: gate
8186
node-version: '24'
8287
project-dir: .
8388
branch: main
8489
json: "true"
8590
summary: "true"
91+
skip-checkout: 'true'
8692
env:
8793
GITHUB_TOKEN: ${{ github.token }}
8894

@@ -98,8 +104,7 @@ jobs:
98104
target_packages: ${{ needs.gate.outputs.target }}
99105
target_branch: main
100106
bump: ${{ needs.gate.outputs.bump }}
101-
stable: 'false'
102-
release_type: prerelease
107+
release_type: ${{ needs.gate.outputs.stable == 'true' && 'stable' || 'prerelease' }}
103108
dry_run: false
104109
scope: ${{ needs.gate.outputs.scope }}
105110
secrets:
@@ -117,7 +122,6 @@ jobs:
117122
with:
118123
target_branch: ${{ inputs.target_branch }}
119124
bump: ${{ inputs.bump }}
120-
stable: 'false'
121125
release_type: ${{ inputs.release_type }}
122126
dry_run: ${{ inputs.dry_run }}
123127
scope: ${{ inputs.scope }}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"devDependencies": {
6666
"@biomejs/biome": "2.4.12",
6767
"@inquirer/prompts": "^8.3.0",
68-
"@releasekit/release": "^0.17.0",
68+
"@releasekit/release": "^0.17.1",
6969
"@types/node": "^25.5.0",
7070
"@typescript-eslint/parser": "^8.57.0",
7171
"@vitest/eslint-plugin": "^1.6.11",

pnpm-lock.yaml

Lines changed: 17 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)