fixes bug related to controller prop

Author: waseemdev

README.md

@@ -126,8 +126,8 @@ import 'home.xml.dart';
 class HomeController extends HomeControllerBase {
 
   //
-  // here you can add you own logic and called the variables and methods
-  // from inside the XML file like this <Text text="ctrl.myText" />
+  // here you can add you own logic and call the variables and methods
+  // from the XML file. e.g. <Text text="ctrl.myText" />
   //
 
   @override

docs/controllers.md

@@ -15,6 +15,10 @@ Another way is to define it within the controller class:
 ```dart
   final myTextEditingController = new TextEditingController();
 ```
+And you can access it in XML:
+```XML
+<TextField controller="ctrl.myTextEditingController" />
+```
 
 Sometimes you might need to access the instance of the State, for example, For AnimationControler to work properly, the current State (which inherets from `SingleTickerProviderStateMixin` [mixin](./mixin.md)) must be passed as parameter: `AnimationController(vsync: this)`. for this case you can define it as a `<var />` in the XML file as follow:
 ```XML

src/generators/class-generator.ts

@@ -129,7 +129,7 @@ export class ClassCodeGenerator {
             ...rootWidget.providers.map(a => this.createControllerVar(a))
         ];
         const disposeLines = [
-          ...controllers.filter(a => !a.isPrivate).map(a => a.name),
+          ...controllers.filter(a => !a.isPrivate && !a.skipGenerate).map(a => a.name),
           ...vars.filter(a => a.type === 'FormGroup').map(a => a.name)
         ];
 

src/resolvers/property-resolver.ts

@@ -139,7 +139,7 @@ export class PropertyResolver {
             value = ValueTransformersProvider.transform(value, propertyName, widget.type);
         }
 
-        if (this.isUnNamedParamaeter(propertyName, ownerWidget.type)) {
+        if (this.isUnNamedParameter(propertyName, ownerWidget.type)) {
             propertyName = '';
         }
 
@@ -152,25 +152,29 @@ export class PropertyResolver {
 
         if (propertyName === 'controller') {
             property.controller = this.createController(propertyValue);
-            property.value = 'ctrl.' + property.controller.name;
-            property.name = 'controller';
+            property.value = (property.controller.name.indexOf('.') > -1 ? '' : 'ctrl.') + property.controller.name;
+            // property.name = 'controller';
         }
 
         return { property, wrapperWidget, handled };
     }
 
     private createController(propertyValue: string): VariableModel {
+        let skipGenerate = false;
         const eqSegments = propertyValue.split('=');
-
-        // e.g. controller="ScrollController myController"
-        let name = eqSegments[0].split(' ')[1];
-        let type = eqSegments[0].split(' ')[0];
+        
+        let name = eqSegments[0].split(' ')[1]; // e.g. get the name from "ScrollController myController"
+        let type = eqSegments[0].split(' ')[0]; // e.g. get the type from "ScrollController myController"
         let value;
 
         // there is a name with out type e.g. controller="myController"
         if (!name) {
             name = type;
             type = '';
+            // e.g. controller="ctrl.myController"
+            if (name.indexOf('.') > -1) {
+                skipGenerate = true;
+            }
         }
 
         // controller="TabController myController = TabController(initialIndex: 0, length: 4, vsync: this)"
@@ -191,10 +195,15 @@ export class PropertyResolver {
             value = value.trim();
         }
 
-        return { type, name, value, skipGenerate: !type && !value };
+        return { type, name, value, skipGenerate: !type && !value || skipGenerate };
     }
 
-    isUnNamedParamaeter(name: string, widgetType: string): boolean {
+    isUnNamedParameter(name: string, widgetType: string): boolean {
+        let result = this.getUnNamedParameter(widgetType) === name;
+        return result;
+    }
+
+    getUnNamedParameter(widgetType: string): string {
         widgetType = widgetType.split('.')[0];
 
         let unnamed: any = {
@@ -207,7 +216,6 @@ export class PropertyResolver {
             unnamed = Object.assign(unnamed, this.config.unnamedProperties);
         }
 
-        let result = unnamed[widgetType] === name;
-        return result;
+        return unnamed[widgetType];
     }
 }

src/resolvers/util.ts

@@ -2,6 +2,10 @@ import { WidgetModel, PropertyModel } from "../models/models";
 
 
 export function removeDuplicatedBuilders(widget: WidgetModel, parent: WidgetModel | WidgetModel[] | null, parentType: 'wrappedWidgets' | 'widget' | 'widgetList', buildersCache: any) {
+    if (!widget) {
+        return;
+    }
+    
     // find and remove duplicated StreamBuilder & FutureBuilder that have same value.
     let detach = false;