Fix

Author: vsdudakov

docs/index.html

@@ -1025,7 +1025,7 @@ <h3>Registering Models</h3>
         file_name: str,
         file_content: bytes,
         obj: Model | None = None,
-    ) -> None:
+    ) -> str:
         """This method is used to upload files.
 
         :params field_name: a name of field.
@@ -3550,7 +3550,7 @@ <h3>Methods and Attributes</h3>
         """
         await self.orm_delete_obj(id)
 
-    async def get_file_url(self, field_name: str, value: str, obj: Model | None = None) -> str:
+    async def get_file_url(self, field_name: str, value: str, obj: Any | None = None) -> str:
         """Return the display URL for an uploaded file field.
 
         Called during serialization for every ``UploadFile`` and ``UploadImage``
@@ -3587,7 +3587,7 @@ <h3>Methods and Attributes</h3>
         field_name: str,
         file_name: str,
         file_content: bytes,
-        obj: Model | None = None,
+        obj: Any | None = None,
     ) -> str:
         """This method is used to upload files.
 
@@ -4233,7 +4233,7 @@ <h3>Registering Inlines</h3>
         file_name: str,
         file_content: bytes,
         obj: Model | None = None,
-    ) -> None:
+    ) -> str:
         """This method is used to upload files.
 
         :params field_name: a name of field.

examples/fastapi_tortoiseorm/example.py

@@ -115,7 +115,7 @@ async def upload_file(
         file_name: str,
         file_content: bytes,
         obj: Model | None = None,
-    ) -> None:
+    ) -> str:
         """This method is used to upload files.
 
         :params field_name: a name of field.

fastadmin/api/service.py

@@ -355,6 +355,8 @@ async def upload_file(
                 file_content,
                 obj=obj,
             )
+        except AdminApiException:
+            raise
         except Exception as e:
             raise AdminApiException(500, detail=f"Error uploading file for {model}: {e}") from e
 

fastadmin/models/base.py

@@ -547,7 +547,7 @@ async def delete_model(self, id: UUID | int | str) -> None:
         """
         await self.orm_delete_obj(id)
 
-    async def get_file_url(self, field_name: str, value: str, obj: Model | None = None) -> str:
+    async def get_file_url(self, field_name: str, value: str, obj: Any | None = None) -> str:
         """Return the display URL for an uploaded file field.
 
         Called during serialization for every ``UploadFile`` and ``UploadImage``
@@ -584,7 +584,7 @@ async def upload_file(
         field_name: str,
         file_name: str,
         file_content: bytes,
-        obj: Model | None = None,
+        obj: Any | None = None,
     ) -> str:
         """This method is used to upload files.
 

fastadmin/models/orms/ponyorm.py

@@ -443,7 +443,7 @@ def orm_save_m2m_ids(self, obj: Any, field: str, ids: list[int | str | UUID]) ->
     @sync_to_async
     @db_session
     def serialize_obj_attributes(
-        self, obj: Any, attributes_to_serizalize: list[ModelFieldWidgetSchema]
+        self, obj: Any, attributes_to_serizalize: list[ModelFieldWidgetSchema], list_view: bool = False
     ) -> dict[str, Any]:
         """Serialize orm model obj attribute to dict.
 

fastadmin/static/index.min.js

@@ -559,6 +559,22 @@ async def test_upload_file_success_with_sync_upload_handler(monkeypatch):
     upload_mock.assert_called_once_with("file", "x.txt", b"content", obj=None)
 
 
+async def test_upload_file_404_when_id_provided_but_obj_not_found(monkeypatch):
+    """id supplied but orm_get_obj returns None — should raise 404, not 500."""
+    monkeypatch.setattr("fastadmin.api.service.get_user_id_from_session_id", AsyncMock(return_value=1))
+    admin_model = SimpleNamespace(
+        set_context=Mock(),
+        orm_get_obj=AsyncMock(return_value=None),
+        upload_file=AsyncMock(return_value="/media/x.txt"),
+    )
+    monkeypatch.setattr("fastadmin.api.service.get_admin_or_admin_inline_model", lambda _model: admin_model)
+    with pytest.raises(AdminApiException) as exc_info:
+        await ApiService().upload_file("sid", "Event", "file", "x.txt", b"content", id=999)
+    assert exc_info.value.status_code == 404
+    assert "not found" in exc_info.value.detail
+    admin_model.upload_file.assert_not_awaited()
+
+
 async def test_upload_file_500_upload_raises(monkeypatch):
     monkeypatch.setattr("fastadmin.api.service.get_user_id_from_session_id", AsyncMock(return_value=1))
     admin_model = SimpleNamespace(