[FEATURE] Add `LOCATION` and `ENVIRONMENT` from `/etc/machine-info`

[jcpunk]

It could be handy to add in facts from /etc/machine-info about a system to help expose these fields if defined.

They should probably be under some sort of structured fact.

Unreviewed idea:

systemd:
  hostnamectl:
    location: place
    environment: name

[ekohl]

Is this something that belongs in Facter/OpenFact?

[jcpunk]

I have no objection to that plan. I'm unsure how this would look on non-systemd distributions.

[smortex]

@jcpunk see OpenVoxProject/openfact#33 which add something similar but using the os-release resolver. I think adding a machine-info resolver would make sense. Maybe instead of having the resolver resolving a single fact at a time, it could collect all info and return a single structured fact.

I'm unsure how this would look on non-systemd distributions.

According to machine-info(5), this is set by the administrator, so even if not using systemd, if the file exist and has info, it make sense to expose it in openfact I think. As a matter of fact, I already setup custom facts city, country, form_factor on my systems that could be replaced by something read from /etc/machine-info… I was not aware of this file, thank you 😃.

[jcpunk]

:) I'm currently trying to get ROLE added to that file as well so I can use it to help feed my ENC.