Added CentOS rake, Add conditional that if virtualenv, then install dev

Author: danquack

.travis.yml

@@ -49,6 +49,12 @@ matrix:
     env: PUPPET_INSTALL_TYPE=agent BEAKER_IS_PE=no BEAKER_PUPPET_COLLECTION=puppet5 BEAKER_debug=true BEAKER_setfile=debian9-64{hypervisor=docker} CHECK=beaker
     services: docker
     sudo: required
+  - rvm: 2.5.1
+    bundler_args: --without development release
+    dist: trusty
+    env: PUPPET_INSTALL_TYPE=agent BEAKER_IS_PE=no BEAKER_PUPPET_COLLECTION=puppet5 BEAKER_debug=true BEAKER_setfile=centos7-64{hypervisor=docker} CHECK=beaker
+    services: docker
+    sudo: required
 branches:
   only:
   - master

manifests/install.pp

@@ -28,12 +28,6 @@
     'Gentoo' => undef,
   }
 
-  $dev_ensure = $python::dev ? {
-    true    => 'present',
-    false   => 'absent',
-    default => $python::dev,
-  }
-
   $pip_ensure = $python::pip ? {
     true    => 'present',
     false   => 'absent',
@@ -46,6 +40,21 @@
     default => $python::virtualenv,
   }
 
+  if ($venv_ensure == 'present') {
+    $dev_ensure = 'present'
+    if ! $python::dev {
+      # Error: python2-devel is needed by (installed) python-virtualenv-15.1.0-2.el7.noarch
+      # Python dev is required for virtual environment, but python environment is not required for python dev.
+      notify { 'Python virtual environment is dependent on python dev': }
+    }
+  } else {
+    $dev_ensure = $python::dev ? {
+      true    => 'present',
+      false   => 'absent',
+      default => $python::dev,
+    }
+  }
+
   package { 'python':
     ensure => $python::ensure,
     name   => $python,
@@ -96,6 +105,7 @@
       Package <| title == 'virtualenv' |> {
         name     => 'virtualenv',
         provider => 'pip',
+        require  => Package['python-dev']
       }
     }
     'scl': {

spec/classes/python_spec.rb

@@ -31,6 +31,16 @@
             end
           end
 
+          describe 'with python::virtualenv, without python::dev' do
+            context 'true' do
+              let(:params) { { dev: 'absent',  virtualenv: 'present' } }
+              it { is_expected.to contain_package('python-dev').with_ensure('present') }
+            end
+            context 'empty/default' do
+              it { is_expected.to contain_package('python-dev').with_ensure('absent') }
+            end
+          end
+
           describe 'with manage_gunicorn' do
             context 'true' do
               let(:params) { { manage_gunicorn: true } }