Fix last bits of data-types inconsistencies

These parameters had mixed types before data-types where added.  Use the
more appropriate data type for each of them.

Author: smortex

manifests/fpm/pool.pp

@@ -123,7 +123,7 @@
 define php::fpm::pool (
   Enum['present', 'absent'] $ensure        = 'present',
   String[1] $listen                        = '127.0.0.1:9000',
-  String[1] $listen_backlog                = '-1',
+  Integer[-1] $listen_backlog              = -1,
   Optional[String[1]] $listen_allowed_clients = undef,
   Optional[String[1]] $listen_owner        = undef,
   Optional[String[1]] $listen_group        = undef,
@@ -132,19 +132,19 @@
   String[1] $group                         = $php::fpm::config::group,
   Optional[String[1]] $apparmor_hat        = undef,
   String[1] $pm                            = 'dynamic',
-  String[1] $pm_max_children               = '50',
-  String[1] $pm_start_servers              = '5',
-  String[1] $pm_min_spare_servers          = '5',
-  String[1] $pm_max_spare_servers          = '35',
-  String[1] $pm_max_requests               = '0',
+  Integer[1] $pm_max_children              = 50,
+  Integer[1] $pm_start_servers             = 5,
+  Integer[0] $pm_min_spare_servers         = 5,
+  Integer[0] $pm_max_spare_servers         = 35,
+  Integer[0] $pm_max_requests              = 0,
   Php::Duration $pm_process_idle_timeout   = '10s',
   Optional[Stdlib::Absolutepath] $pm_status_path = undef,
   Optional[Stdlib::Absolutepath] $ping_path = undef,
   String[1] $ping_response                 = 'pong',
   Optional[Stdlib::Absolutepath] $access_log = undef,
   String[1] $access_log_format             = '"%R - %u %t \"%m %r\" %s"',
-  String[1] $request_terminate_timeout     = '0',
-  String[1] $request_slowlog_timeout       = '0',
+  Integer[0] $request_terminate_timeout    = 0,
+  Integer[0] $request_slowlog_timeout      = 0,
   Array[String[1]] $security_limit_extensions = [],
   Stdlib::Absolutepath $slowlog            = "/var/log/php-fpm/${name}-slow.log",
   String[1] $template                      = 'php/fpm/pool.conf.erb',

manifests/params.pp

@@ -18,14 +18,14 @@
     'www' => {
       'catch_workers_output'      => 'no',
       'listen'                    => '127.0.0.1:9000',
-      'listen_backlog'            => '-1',
+      'listen_backlog'            => -1,
       'pm'                        => 'dynamic',
-      'pm_max_children'           => '50',
-      'pm_max_requests'           => '0',
-      'pm_max_spare_servers'      => '35',
-      'pm_min_spare_servers'      => '5',
-      'pm_start_servers'          => '5',
-      'request_terminate_timeout' => '0',
+      'pm_max_children'           => 50,
+      'pm_max_requests'           => 0,
+      'pm_max_spare_servers'      => 35,
+      'pm_min_spare_servers'      => 5,
+      'pm_start_servers'          => 5,
+      'request_terminate_timeout' => 0,
     },
   }