move from pin to priority for debian

Author: alaunay

manifests/params.pp

@@ -5,7 +5,10 @@
   $nodejs_package_ensure       = 'installed'
   $repo_ensure                 = 'present'
   $repo_pin                    = undef
-  $repo_priority               = fact('os.family') == 'Debian' ? '990' : 'absent'
+  $repo_priority               = $facts['os']['family'] == 'Debian' ? {
+    true    => '990',
+    default => 'absent',
+  }
   $repo_proxy                  = 'absent'
   $repo_proxy_password         = 'absent'
   $repo_proxy_username         = 'absent'

spec/acceptance/class_spec.rb

@@ -42,7 +42,7 @@ def nodesource_unsupported(nodejs_version)
 
     # Debian 12 contains NodeJS 18, when we test 16 and 18, we need to force the nodesource version
     # as Debians versions *can* be newer
-    repo_pin =
+    repo_priority =
       if fact('os.family') == 'Debian'
         '990'
       else
@@ -54,7 +54,7 @@ def nodesource_unsupported(nodejs_version)
         <<-PUPPET
         class { 'nodejs':
           repo_version => '#{nodejs_version}',
-          repo_pin => #{repo_pin},
+          repo_priority => #{repo_priority},
         }
         PUPPET
       end

spec/classes/nodejs_spec.rb

@@ -84,23 +84,23 @@
           end
         end
 
-        context 'and repo_pin set to 10' do
+        context 'and repo_priority set to 10' do
           let :params do
-            default_params.merge!(repo_pin: '10')
+            default_params.merge!(repo_priority: '10')
           end
 
-          it 'the repo apt::source resource should contain pin = 10' do
-            is_expected.to contain_apt__source('nodesource').with('pin' => '10')
+          it 'the repo apt::source resource should contain priority = 10' do
+            is_expected.to contain_apt__pin('nodesource').with('priority' => '10')
           end
         end
 
-        context 'and repo_pin not set' do
+        context 'and repo_priority not set' do
           let :params do
-            default_params.merge!(repo_pin: :undef)
+            default_params.merge!(repo_priority: :undef)
           end
 
-          it 'the repo apt::source resource should contain pin = undef' do
-            is_expected.to contain_apt__source('nodesource').with('pin' => nil)
+          it 'the repo apt::source resource should contain priority = 990' do
+            is_expected.to contain_apt__pin('nodesource').with('priority' => 990)
           end
         end
 
@@ -109,8 +109,8 @@
             default_params.merge!(repo_version: '9')
           end
 
-          it 'the repo apt::source resource should contain location = https://deb.nodesource.com/node_9.x' do
-            is_expected.to contain_apt__source('nodesource').with('location' => 'https://deb.nodesource.com/node_9.x')
+          it 'the repo apt::source resource should contain location = [https://deb.nodesource.com/node_9.x]' do
+            is_expected.to contain_apt__source('nodesource').with('location' => ['https://deb.nodesource.com/node_9.x'])
           end
         end