Merge pull request #514 from voxpupuli/plumbing/issues/78

refactor: change from mocha to rspec-mocks

Author: bastelfreak

.rubocop.yml

@@ -1,4 +1,6 @@
 ---
+inherit_from: .rubocop_todo.yml
+
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 

.rubocop_todo.yml

@@ -0,0 +1,18 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config --no-auto-gen-timestamp`
+# using RuboCop version 1.50.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 10
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
+# Offense count: 4
+RSpec/StubbedMock:
+  Exclude:
+    - 'spec/unit/puppet/provider/package/npm_spec.rb'

.sync.yml

@@ -1,12 +1,6 @@
 ---
-spec/spec_helper.rb:
-  mock_with: ':mocha'
 spec/spec_helper_acceptance.rb:
   unmanaged: true
 .github/workflows/ci.yml:
   with:
     beaker_facter: 'nodejs_version:NodeJS:16,18,20,22'
-Gemfile:
-  optional:
-    ':test':
-      - gem: 'mocha'

Gemfile

@@ -6,7 +6,6 @@ source ENV['GEM_SOURCE'] || 'https://rubygems.org'
 group :test do
   gem 'voxpupuli-test', '~> 11.0',  :require => false
   gem 'puppet_metadata', '~> 5.0',  :require => false
-  gem 'mocha',                      :require => false
 end
 
 group :development do

spec/spec_helper.rb

@@ -11,7 +11,6 @@
 
 RSpec.configure do |c|
   c.facterdb_string_keys = false
-  c.mock_with :mocha
 end
 
 add_mocked_facts!

spec/unit/puppet/provider/package/npm_spec.rb

@@ -17,7 +17,7 @@
   end
 
   before do
-    provider.class.stubs(:command).with(:npm).returns '/usr/local/bin/npm'
+    allow(provider.class).to receive(:command).with(:npm).and_return('/usr/local/bin/npm')
     resource.provider = provider
   end
 
@@ -33,27 +33,27 @@ def self.it_should_respond_to(*actions)
 
   describe 'when installing npm packages' do
     it 'uses package name by default' do
-      provider.expects(:npm).with('install', '--global', 'express')
+      expect(provider).to receive(:npm).with('install', '--global', 'express')
       provider.install
     end
 
     it 'uses the source instead of the package name' do
       resource[:source] = '/tmp/express.tar.gz'
-      provider.expects(:npm).with('install', '--global', '/tmp/express.tar.gz')
+      expect(provider).to receive(:npm).with('install', '--global', '/tmp/express.tar.gz')
       provider.install
     end
 
     it 'passes the install_options to npm' do
       resource[:install_options] = ['--verbose']
-      provider.expects(:npm).with('install', '--global', '--verbose', 'express')
+      expect(provider).to receive(:npm).with('install', '--global', '--verbose', 'express')
       provider.install
     end
   end
 
   describe 'and install_options is a hash' do
     it 'passes the install_options to npm' do
       resource[:install_options] = [{ '--loglevel' => 'error' }]
-      provider.expects(:npm).with('install', '--global', '--loglevel=error', 'express')
+      expect(provider).to receive(:npm).with('install', '--global', '--loglevel=error', 'express')
       provider.install
     end
   end
@@ -64,35 +64,35 @@ def self.it_should_respond_to(*actions)
     end
 
     it 'returns a list of npm packages installed globally' do
-      provider.class.expects(:execute).
+      expect(provider.class).to receive(:execute).
         with(['/usr/local/bin/npm', 'list', '--json', '--global'], anything).
-        returns(Puppet::Util::Execution::ProcessOutput.new(File.read('spec/fixtures/unit/puppet/provider/package/npm/npm_global'), 0))
+        and_return(Puppet::Util::Execution::ProcessOutput.new(File.read('spec/fixtures/unit/puppet/provider/package/npm/npm_global'), 0))
       expect(provider.class.instances.map(&:properties).sort_by { |res| res[:name] }).to eq([
                                                                                               { ensure: '2.5.9', provider: 'npm', name: 'express' },
                                                                                               { ensure: '1.1.15', provider: 'npm', name: 'npm' }
                                                                                             ])
     end
 
     it 'logs and continue if the list command has a non-zero exit code' do
-      provider.class.expects(:execute).
+      expect(provider.class).to receive(:execute).
         with(['/usr/local/bin/npm', 'list', '--json', '--global'], anything).
-        returns(Puppet::Util::Execution::ProcessOutput.new(File.read('spec/fixtures/unit/puppet/provider/package/npm/npm_global'), 123))
-      Puppet.expects(:debug).with(regexp_matches(%r{123}))
+        and_return(Puppet::Util::Execution::ProcessOutput.new(File.read('spec/fixtures/unit/puppet/provider/package/npm/npm_global'), 123))
+      expect(Puppet).to receive(:debug).with(a_string_matching(%r{123}))
       expect(provider.class.instances.map(&:properties)).not_to eq([])
     end
 
     it "logs and return no packages if JSON isn't output" do
-      provider.class.expects(:execute).
+      expect(provider.class).to receive(:execute).
         with(['/usr/local/bin/npm', 'list', '--json', '--global'], anything).
-        returns(Puppet::Util::Execution::ProcessOutput.new('failure!', 0))
-      Puppet.expects(:debug).with(regexp_matches(%r{npm list.*failure!}))
+        and_return(Puppet::Util::Execution::ProcessOutput.new('failure!', 0))
+      expect(Puppet).to receive(:debug).with(a_string_matching(%r{npm list.*failure!}))
       expect(provider.class.instances).to eq([])
     end
   end
 
   describe '#latest' do
     it 'filters npm registry logging' do
-      provider.expects(:npm).with('view', 'express', 'version').returns("npm http GET https://registry.npmjs.org/express\nnpm http 200 https://registry.npmjs.org/express\n2.0.0")
+      expect(provider).to receive(:npm).with('view', 'express', 'version').and_return("npm http GET https://registry.npmjs.org/express\nnpm http 200 https://registry.npmjs.org/express\n2.0.0")
       expect(provider.latest).to eq('2.0.0')
     end
   end