rubocop: autofix

Author: bastelfreak

.rubocop.yml

@@ -1,4 +1,6 @@
 ---
+inherit_from: .rubocop_todo.yml
+
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 

.rubocop_todo.yml

@@ -0,0 +1,87 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2023-08-17 21:34:59 UTC using RuboCop version 1.50.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
+Lint/DuplicateBranch:
+  Exclude:
+    - 'lib/puppet/provider/mongodb.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'spec/unit/puppet/provider/mongodb_shard/mongodb_spec.rb'
+
+# Offense count: 1
+Lint/SelfAssignment:
+  Exclude:
+    - 'lib/puppet/provider/mongodb_replset/mongo.rb'
+
+# Offense count: 7
+# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
+# SupportedStyles: snake_case, normalcase, non_integer
+# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
+Naming/VariableNumber:
+  Exclude:
+    - 'lib/puppet/provider/mongodb_user/mongodb.rb'
+    - 'lib/puppet/type/mongodb_user.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/BeEq:
+  Exclude:
+    - 'spec/functions/mongodb_password_spec.rb'
+
+# Offense count: 1
+RSpec/MultipleExpectations:
+  Max: 2
+
+# Offense count: 6
+RSpec/RepeatedExampleGroupBody:
+  Exclude:
+    - 'spec/acceptance/mongos_spec.rb'
+    - 'spec/acceptance/server_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle, AllowedPatterns.
+# SupportedStyles: snake_case, camelCase
+RSpec/VariableName:
+  Exclude:
+    - 'spec/classes/server_spec.rb'
+
+# Offense count: 44
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedReceivers.
+# AllowedReceivers: Thread.current
+Style/HashEachMethods:
+  Exclude:
+    - 'lib/puppet/provider/mongodb_database/mongodb.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/puppet/provider/mongodb.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Mode.
+Style/StringConcatenation:
+  Exclude:
+    - 'lib/puppet/provider/mongodb_database/mongodb.rb'

spec/defines/db_spec.rb

@@ -24,13 +24,13 @@
 
     it 'contains mongodb_user with proper roles' do
       params['roles'] = %w[testrole1 testrole2]
-      is_expected.to contain_mongodb_user('User testuser on db testdb').\
+      is_expected.to contain_mongodb_user('User testuser on db testdb'). \
         with_roles(%w[testrole1 testrole2])
     end
 
     it 'prefers password_hash instead of password' do
       params['password_hash'] = 'securehash'
-      is_expected.to contain_mongodb_user('User testuser on db testdb').\
+      is_expected.to contain_mongodb_user('User testuser on db testdb'). \
         with_password_hash('securehash')
     end
 
@@ -64,13 +64,13 @@
 
     it 'contains mongodb_user with proper roles' do
       params['roles'] = %w[testrole1 testrole2]
-      is_expected.to contain_mongodb_user('User testuser on db testdb').\
+      is_expected.to contain_mongodb_user('User testuser on db testdb'). \
         with_roles(%w[testrole1 testrole2])
     end
 
     it 'prefers password_hash instead of password' do
       params['password_hash'] = 'securehash'
-      is_expected.to contain_mongodb_user('User testuser on db testdb').\
+      is_expected.to contain_mongodb_user('User testuser on db testdb'). \
         with_password_hash('securehash')
     end
 

spec/unit/puppet/provider/mongodb_shard/mongodb_spec.rb

@@ -25,7 +25,7 @@
         'version' => 4,
         'minCompatibleVersion' => 4,
         'currentVersion' => 5,
-        'clusterId' => "ObjectId(\'548e9110f3aca177c94c5e49\')"
+        'clusterId' => "ObjectId('548e9110f3aca177c94c5e49')"
       },
       'shards' => [
         {  '_id' => 'rs_test', 'host' => 'rs_test/mongo1:27018' }

spec/unit/puppet/provider/mongodb_user/mongodb_spec.rb

@@ -47,7 +47,7 @@
   describe 'empty self.instances from slave' do
     it 'doesn`t retrun array of users' do
       allow(provider.class).to receive(:db_ismaster).and_return(false)
-      expect(provider.class.instances).to match_array([])
+      expect(provider.class.instances).to be_empty
     end
   end