Merge pull request #228 from dprince/revert_auth_enabled

Revert "Initiate replica set creation from

Author: hunner

lib/puppet/provider/mongodb_replset/mongo.rb

@@ -94,10 +94,6 @@ def rs_add_arbiter(host, master)
     mongo_command("rs.addArb(\"#{host}\")", master)
   end
 
-  def auth_enabled
-    @resource[:auth_enabled]
-  end
-
   def master_host(hosts)
     hosts.each do |host|
       status = db_ismaster(host)
@@ -139,36 +135,31 @@ def self.get_replset_properties
   end
 
   def alive_members(hosts)
-    alive = []
     hosts.select do |host|
       begin
         Puppet.debug "Checking replicaset member #{host} ..."
         status = rs_status(host)
         if status.has_key?('errmsg') and status['errmsg'] == 'not running with --replSet'
           raise Puppet::Error, "Can't configure replicaset #{self.name}, host #{host} is not supposed to be part of a replicaset."
         end
-
-        if auth_enabled and status.has_key?('errmsg') and (status['errmsg'].include? "unauthorized" or status['errmsg'].include? "not authorized")
-          Puppet.warning "Host #{host} is available, but you are unauthorized because of authentication is enabled: #{auth_enabled}"
-          alive.push(host)
-        end
-
         if status.has_key?('set')
           if status['set'] != self.name
             raise Puppet::Error, "Can't configure replicaset #{self.name}, host #{host} is already part of another replicaset."
           end
 
           # This node is alive and supposed to be a member of our set
           Puppet.debug "Host #{host} is available for replset #{status['set']}"
-          alive.push(host)
+          true
         elsif status.has_key?('info')
           Puppet.debug "Host #{host} is alive but unconfigured: #{status['info']}"
+          true
         end
       rescue Puppet::ExecutionFailure
         Puppet.warning "Can't connect to replicaset member #{host}."
+
+        false
       end
     end
-    return alive
   end
 
   def set_members
@@ -234,17 +225,10 @@ def set_members
   end
 
   def mongo_command(command, host, retries=4)
-    self.class.mongo_command(command,host,retries,auth_enabled)
+    self.class.mongo_command(command,host,retries)
   end
 
-  def self.mongo_command(command, host=nil, retries=4, auth_enabled=false)
-    if auth_enabled and command =~ 'rs.initiate'
-      # We can't setup replica from any hosts except localhost
-      # if authentication is enabled
-      # User can't be created before replica set initialization
-      # So we can't use user credentials for auth
-      host = '127.0.0.1'
-    end
+  def self.mongo_command(command, host=nil, retries=4)
     # Allow waiting for mongod to become ready
     # Wait for 2 seconds initially and double the delay at each retry
     wait = 2

lib/puppet/type/mongodb_replset.rb

@@ -17,11 +17,6 @@
     desc "The name of the replicaSet"
   end
 
-  newparam(:auth_enabled) do
-    desc "Check authentication enabled"
-    defaultto false
-  end
-
   newparam(:arbiter) do
     desc "The replicaSet arbiter"
   end