rubocop: autofix

Author: bastelfreak

.rubocop.yml

@@ -1,4 +1,6 @@
 ---
+inherit_from: .rubocop_todo.yml
+
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 

.rubocop_todo.yml

@@ -0,0 +1,20 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2023-08-17 21:26:09 UTC using RuboCop version 1.50.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Lint/NonAtomicFileOperation:
+  Exclude:
+    - 'lib/puppet/provider/archive/ruby.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowComments.
+Style/RedundantInitialize:
+  Exclude:
+    - 'lib/puppet_x/bodeco/util.rb'

lib/puppet/type/archive.rb

@@ -208,7 +208,7 @@ def should_to_s(value)
     desc 'optional header(s) to pass.'
 
     validate do |val|
-      raise ArgumentError, "headers must be an array: #{val}" unless val.is_a?(::Array)
+      raise ArgumentError, "headers must be an array: #{val}" unless val.is_a?(Array)
     end
   end
 
@@ -238,12 +238,12 @@ def should_to_s(value)
     desc 'provider download options (affects curl, wget, gs, and only s3 downloads for ruby provider)'
 
     validate do |val|
-      raise ArgumentError, "download_options should be String or Array: #{val}" unless val.is_a?(::String) || val.is_a?(::Array)
+      raise ArgumentError, "download_options should be String or Array: #{val}" unless val.is_a?(String) || val.is_a?(Array)
     end
 
     munge do |val|
       case val
-      when ::String
+      when String
         [val]
       else
         val

lib/puppet_x/bodeco/archive.rb

@@ -79,7 +79,7 @@ def win_7zip
               Add-Type -AssemblyName System.IO.Compression.FileSystem -erroraction "silentlycontinue"
               $zipFile = [System.IO.Compression.ZipFile]::openread(#{@file_path})
               foreach ($zipFileEntry in $zipFile.Entries) {
-                  $pwd = (Get-Item -Path ".\" -Verbose).FullName
+                  $pwd = (Get-Item -Path "." -Verbose).FullName
                   $outputFile = [io.path]::combine($pwd, $zipFileEntry.FullName)
                   $dir = ([io.fileinfo]$outputFile).DirectoryName
 

lib/puppet_x/bodeco/util.rb

@@ -33,7 +33,7 @@ def self.puppet_download(url, filepath)
         status = load_file_with_any_terminus(url)
         raise ArgumentError, "Previous error(s) resulted in Puppet being unable to retrieve information from environment #{Puppet['environment']} source(s) #{url}'\nMost probable cause is file not found." unless status
 
-        File.open(filepath, 'wb') { |file| file.write(status.content) }
+        File.binwrite(filepath, status.content)
       end
 
       # @private

spec/functions/archive_go_md5_spec.rb

@@ -17,7 +17,7 @@
   context 'when file doesn\'t exist' do
     it 'raises error' do
       allow(PuppetX::Bodeco::Util).to receive(:content).with(uri, username: 'user', password: 'pass').and_return(example_md5)
-      expect(subject).to run.with_params('user', 'pass', 'non-existent-file', url).and_raise_error(RuntimeError, "Could not parse md5 from url https://gocd\.lan/path/file\.md5 response: #{example_md5}")
+      expect(subject).to run.with_params('user', 'pass', 'non-existent-file', url).and_raise_error(RuntimeError, "Could not parse md5 from url https://gocd.lan/path/file.md5 response: #{example_md5}")
     end
   end
 end

spec/unit/puppet/provider/archive/curl_spec.rb

@@ -58,7 +58,7 @@
       it 'populates temp netrc file with credentials' do
         allow(provider).to receive(:delete_netrcfile) # Don't delete the file or we won't be able to examine its contents.
         provider.download(name)
-        nettc_content = File.open(tempfile.path).read
+        nettc_content = File.read(tempfile.path)
         expect(nettc_content).to eq("machine home.lan\nlogin foo\npassword bar\n")
       end
 

spec/unit/puppet/provider/archive/gs_spec.rb

@@ -46,7 +46,7 @@
 
       before do
         resource[:checksum_url] = url if url
-        allow(PuppetX::Bodeco::Util).to receive(:content).\
+        allow(PuppetX::Bodeco::Util).to receive(:content). \
           with(url, any_args).and_return(remote_hash)
       end
 

spec/unit/puppet/provider/archive/ruby_spec.rb

@@ -46,7 +46,7 @@
 
       before do
         resource[:checksum_url] = url if url
-        allow(PuppetX::Bodeco::Util).to receive(:content).\
+        allow(PuppetX::Bodeco::Util).to receive(:content). \
           with(url, any_args).and_return(remote_hash)
       end