Skip to content

Commit 0e18cb0

Browse files
committed
Move all static validations to the setup job
The default rake task is release_checks. This runs `lint`, `validate` prior to `parallel_spec` and ends with the `check` task. These static tasks shouldn't differ for the matrix job and can be run prior to running the whole test suite. Then in the actual test matrix, it only needs to run the tests (in parallel). This saves some CI resources when a static check fails.
1 parent 5e2741c commit 0e18cb0

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

moduleroot/.github/workflows/ci.yml.erb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ jobs:
2020
with:
2121
ruby-version: '2.7'
2222
bundler-cache: true
23-
- name: Run rake validate
24-
run: bundle exec rake validate
23+
- name: Run static validations
24+
run: bundle exec rake validate lint check
2525
- name: Run rake rubocop
2626
run: bundle exec rake rubocop
2727
- name: Setup Test Matrix
@@ -48,7 +48,7 @@ jobs:
4848
ruby-version: ${{ matrix.ruby }}
4949
bundler-cache: true
5050
- name: Run tests
51-
run: bundle exec rake
51+
run: bundle exec rake parallel_spec
5252
<%- if Dir[File.join(@metadata[:workdir], 'spec', 'acceptance', '**', '*_spec.rb')].any? -%>
5353

5454
acceptance:

0 commit comments

Comments
 (0)