Configure oxlint, address some lint warnings (#1690)

Author: askoufis

.oxlintrc.json

@@ -0,0 +1,4 @@
+{
+  "$schema": "./node_modules/oxlint/configuration_schema.json",
+  "ignorePatterns": ["packages/webpack-plugin/extracted.js"]
+}

.prettierignore

@@ -13,3 +13,4 @@ pnpm-lock.yaml
 test-results
 examples/remix/build
 .pnpm-store
+next-env.d.ts

package.json

@@ -19,11 +19,12 @@
     "test:playwright": "pnpm test:clean-next && pnpm test:build-next && playwright test",
     "test:clean-next": "pnpm --filter=@fixtures/next-* run '/^clean.*/'",
     "test:build-next": "node scripts/copy-next-plugin.ts && pnpm --filter=@fixtures/next-* run '/^build.*/'",
-    "format": "prettier --write .",
-    "lint": "pnpm run '/^lint:.*/'",
+    "format": "oxlint --fix && prettier --write .",
+    "lint": "pnpm run --no-bail '/^lint:.*/'",
     "lint:manypkg": "manypkg check",
     "lint:prettier": "prettier --cache --check .",
     "lint:tsc": "tsc",
+    "lint:oxlint": "oxlint",
     "copy-readme-to-packages": "node scripts/copy-readme-to-packages.ts",
     "version": "changeset version && pnpm install --lockfile-only",
     "prepare-release": "pnpm copy-readme-to-packages && pnpm build",
@@ -47,6 +48,7 @@
     "cross-env": "^7.0.3",
     "jest": "^29.7.0",
     "jest-environment-jsdom": "^29.7.0",
+    "oxlint": "^1.55.0",
     "prettier": "^3.8.1",
     "tsx": "^4.20.6",
     "typescript": "^5.8.3",
@@ -63,5 +65,5 @@
   "manypkg": {
     "workspaceProtocol": "require"
   },
-  "packageManager": "pnpm@10.24.0"
+  "packageManager": "pnpm@10.32.0"
 }

packages/css/src/conditionalRulesets.ts

@@ -46,6 +46,8 @@ export class ConditionalRuleset {
   }
 
   getConditionalRulesetByPath(conditionPath: Array<Query>): ConditionalRuleset {
+    // Couldn't fine a way around this
+    // oxlint-disable-next-line typescript/no-this-alias
     let currRuleset: ConditionalRuleset = this;
 
     for (const query of conditionPath) {

packages/next-plugin/src/index.ts

@@ -40,7 +40,7 @@ function getSupportedBrowsers(dir: string, isDevelopment: boolean) {
       path: dir,
       env: isDevelopment ? 'development' : 'production',
     });
-  } catch (_) {
+  } catch {
     return undefined;
   }
 }
@@ -184,7 +184,7 @@ export const createVanillaExtractPlugin = (
 
     let turbopack: typeof nextConfig.turbopack;
     if (enableTurbopack) {
-      turbopack = { ...(nextConfig.turbopack || {}) };
+      turbopack = { ...nextConfig.turbopack };
 
       if (turbopackGlob.some((glob) => turbopack.rules?.[glob])) {
         throw new Error(
@@ -212,7 +212,7 @@ export const createVanillaExtractPlugin = (
       } as const;
 
       turbopack.rules = {
-        ...(turbopack.rules || {}),
+        ...turbopack.rules,
         ...Object.fromEntries(
           turbopackGlob.map((glob) => [glob, vanillaExtractRule]),
         ),

packages/turbopack-plugin/src/next-font/transform.ts

@@ -28,7 +28,7 @@ const GENERIC_FAMILIES = new Set([
 // --- Helpers ---
 
 function formatFontFamily(name: string): string {
-  const clean = name.replace(/['\"]/g, '');
+  const clean = name.replace(/['"]/g, '');
   return GENERIC_FAMILIES.has(clean.toLowerCase()) ? clean : `'${clean}'`;
 }
 
@@ -213,8 +213,8 @@ export async function transformNextFont(
 ): Promise<NextFontTransformResult> {
   // 1. Parse
   const isTs = /\.(?:[cm]?ts|tsx)$/.test(filename);
-  const isTsx = /\.tsx$/.test(filename);
-  const isJsx = /\.jsx$/.test(filename);
+  const isTsx = filename.endsWith('.tsx');
+  const isJsx = filename.endsWith('.jsx');
 
   const module = await swc.parse(code, {
     syntax: isTs ? 'typescript' : 'ecmascript',