Exit 1 for testharness if any tests fail

This change makes TokenizerTester, TreeTester, and EncodingTester exit
with status code 1 if any test cases fail.

Otherwise, without this change, we won’t catch the test failures when
running tests under CI.

Author: sideshowbarker

test-src/nu/validator/htmlparser/test/EncodingTester.java

@@ -36,6 +36,10 @@
 
 public class EncodingTester {
 
+    protected static int SNIFFING_LIMIT = 16384;
+
+    private static int exitStatus = 0;
+
     private final InputStream aggregateStream;
 
     private final StringBuilder builder = new StringBuilder();
@@ -63,6 +67,7 @@ private boolean runTest() throws IOException, SAXException {
         Charset charset = reader.getCharset();
         stream.close();
         if (skipLabel()) {
+            exitStatus = 1;
             System.err.println("Premature end of test data.");
             return false;
         }
@@ -73,6 +78,7 @@ private boolean runTest() throws IOException, SAXException {
                 case '\n':
                     break loop;
                 case -1:
+                    exitStatus = 1;
                     System.err.println("Premature end of test data.");
                     return false;
                 default:
@@ -85,6 +91,7 @@ private boolean runTest() throws IOException, SAXException {
             System.err.println("Success.");
             // System.err.println(stream);
         } else {
+            exitStatus = 1;
             System.err.println("Failure. Expected: " + expected + " got "
                     + sniffed + ".");
             System.err.println(stream);
@@ -118,6 +125,7 @@ public static void main(String[] args) throws IOException, SAXException {
                     args[i]));
             tester.runTests();
         }
+        System.exit(exitStatus);
     }
 
 }

test-src/nu/validator/htmlparser/test/TokenizerTester.java

@@ -56,6 +56,8 @@
 
 public class TokenizerTester {
 
+    private static int exitStatus = 0;
+
     private static JSONString PLAINTEXT = new JSONString("PLAINTEXT state");
 
     private static JSONString PCDATA = new JSONString("Data state");
@@ -191,6 +193,7 @@ private void runTestInner(String inputString, JSONArray expectedTokens,
             if (jsonDeepEquals(actualTokens, expectedTokens)) {
                 writer.write("Success\n");
             } else {
+                exitStatus = 1;
                 writer.write("Failure\n");
                 writer.write(description);
                 writer.write("\nInput:\n");
@@ -202,6 +205,7 @@ private void runTestInner(String inputString, JSONArray expectedTokens,
                 writer.write("\n");
             }
         } catch (Throwable t) {
+            exitStatus = 1;
             writer.write("Failure\n");
             writer.write(description);
             writer.write("\nInput:\n");
@@ -254,6 +258,7 @@ public static void main(String[] args) throws Throwable {
                 tester.test(file.getPath().toString());
             }
         }
+        System.exit(exitStatus);
     }
 
 }

test-src/nu/validator/htmlparser/test/TreeTester.java

@@ -44,6 +44,8 @@ public class TreeTester {
 
     private boolean streaming = false;
 
+    private static int exitStatus = 0;
+
     /**
      * @param aggregateStream
      */
@@ -229,6 +231,7 @@ private boolean runTest() throws Throwable {
                 System.err.println("Success.");
                 // System.err.println(stream);
             } else {
+                exitStatus = 1;
                 System.err.print("Failure.\nData:\n" + stream + "\nExpected:\n"
                         + expected + "Got: \n" + actual);
                 System.err.println("Expected errors:");
@@ -241,6 +244,7 @@ private boolean runTest() throws Throwable {
                 }
             }
         } catch (Throwable t) {
+            exitStatus = 1;
             System.err.println("Failure.\nData:\n" + stream);
             throw t;
         }
@@ -292,6 +296,7 @@ public static void main(String[] args) throws Throwable {
                 tester.runTests(file.getPath().toString());
             }
         }
+        System.exit(exitStatus);
     }
 
 }