Skip to content

Commit 09c1126

Browse files
More spelling fixes, refinement of cspell configuration
1 parent 14c5c30 commit 09c1126

4 files changed

Lines changed: 42 additions & 11 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
},
7777
{
7878
"name": "Check spelling",
79-
"run": "cspell 'src/**/*.ts'"
79+
"run": "cspell '**'"
8080
}
8181
]
8282
}

CHANGELOG.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,14 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
77

88
## [Unreleased]
99

10+
[//]: # (spell-checker:disable)
11+
1012
### Changed
1113
- Name of bundle class, existing symbol name preserved to maintain compatibility.
1214
- Deprecated export `BundleOrchastrator` in favour of `BundleOrchestrator`
1315

16+
[//]: # (spell-checker:enable)
17+
1418
## [4.0.0] - 2020-03-14
1519

1620
## [4.0.0-rc.1] - 2020-02-22
@@ -40,7 +44,7 @@ This release focuses on improving performance and maintainability. These have be
4044
- Logging interface, now uses [`ts-log`](https://www.npmjs.com/package/ts-log).
4145

4246
### Removed
43-
- Virtual path logic in favour of [`@userfrosting/vinly-fs-vpath`](https://github.com/userfrosting/vinyl-fs-vpath).
47+
- Virtual path logic in favour of [`@userfrosting/vinyl-fs-vpath`](https://github.com/userfrosting/vinyl-fs-vpath).
4448

4549
### Fixed
4650
- Flaw in results API surface, results are now correctly separated according to their type (script/style).
@@ -67,7 +71,7 @@ This release focuses on simplifying the package for UserFrosting 4 to improve ma
6771
### Added
6872
- Raw configuration validation.
6973
- Raw configuration merging with collision logic (ported from UserFrosting `gulpfile`).
70-
- Path transformation with support for file replacement based on rule order (later rules superseed earlier ones).
74+
- Path transformation with support for file replacement based on rule order (later rules supersede earlier ones).
7175
- Ability to specify base path for resolution of bundle resources and path transformations.
7276
- Support for comprehensive logging through a passed logger function.
7377

@@ -77,7 +81,7 @@ This release focuses on simplifying the package for UserFrosting 4 to improve ma
7781
- As an internal `gulp` pipeline is no longer responsible for bundle generation, custom `Transform` streams (e.g. `gulp-concat-css`) must be provided.
7882
- Path transformations will no longer be applied to files due to complexity around how paths are managed in `gulp`. Instead this feature will be used for override logic alone.
7983
- Bundle results are now retrieved via a callback which is given a collection of `Vinyl` `NullFiles` to retain as much useful information as possible.
80-
- Moved package under `@userfrosting` organisation in NPM and removed superfluous `uf` from package name.
84+
- Moved package under `@userfrosting` organization in NPM and removed superfluous `uf` from package name.
8185

8286
### Removed
8387
- Support for CSS sourcemaps (broken since 2.27.2).
@@ -89,7 +93,7 @@ This release focuses on simplifying the package for UserFrosting 4 to improve ma
8993
- Automatic HTML tag generation for results file (use results callback to implement this manually).
9094
- File copy support (use `gulp.dest` or an equivalent).
9195
- Result file support (replaced by callback).
92-
- Removed dependency on `gulp` as per best practises.
96+
- Removed dependency on `gulp` as per best practices.
9397

9498
## [2.28.2] - 2018-02-10
9599

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
| master | [![Continuous Integration](https://github.com/userfrosting/gulp-uf-bundle-assets/workflows/Continuous%20Integration/badge.svg?branch=master)](https://github.com/userfrosting/gulp-uf-bundle-assets/actions?query=branch:master+workflow:"Continuous+Integration") [![codecov](https://codecov.io/gh/userfrosting/gulp-uf-bundle-assets/branch/master/graph/badge.svg)](https://codecov.io/gh/userfrosting/gulp-uf-bundle-assets/branch/master) |
66
| develop | [![Continuous Integration](https://github.com/userfrosting/gulp-uf-bundle-assets/workflows/Continuous%20Integration/badge.svg?branch=develop)](https://github.com/userfrosting/gulp-uf-bundle-assets/actions?query=branch:develop+workflow:"Continuous+Integration") [![codecov](https://codecov.io/gh/userfrosting/gulp-uf-bundle-assets/branch/develop/graph/badge.svg)](https://codecov.io/gh/userfrosting/gulp-uf-bundle-assets/branch/develop) |
77

8-
Orchastrates JS and CSS bundle creation in an efficient and configurable manner.
8+
Orchestrates JS and CSS bundle creation in an efficient and configurable manner.
99

1010
## Install
1111

@@ -68,7 +68,7 @@ $ gulp bundle
6868

6969
The `Bundler` class exposes a `ResultsMap` property containing a Map where the key is the bundle name and value the full path of the generated file. If any transform stream after `Bundler` that changes path names then the results map will no longer be accurate, so use the built in path transforms if possible.
7070

71-
This approach was decided on as it provides the most efficient means to integrate bundles with any system. No need to touch the file system until its absolutely necessary, and less work to optimise the output (e.g. make a `php` file out of it to reduce IO in production by maximising use of bytecode caching).
71+
This approach was decided on as it provides the most efficient means to integrate bundles with any system. No need to touch the file system until its absolutely necessary, and less work to optimise the output (e.g. make a `php` file out of it to reduce IO in production by maximizing use of bytecode caching).
7272

7373
## API
7474

@@ -79,9 +79,9 @@ The results reside in [docs/api](./docs/api/index.md).
7979

8080
This plugin was originally forked from [gulp-bundle-assets](https://github.com/dowjones/gulp-bundle-assets) to fix a CSS import bug.
8181

82-
It has since been entirely reworked to better suit the requirements of the UserFrosting's Sprinkle system and follow the Gulp plugin guidelines (namely not unncessarily depending on it). Though TypeScript is now the preferred language the output targetted to ES2015 and uses ES Modules (via the `esm` package) to ensure source it can be easily debugged if issues are observed in the wild.
82+
It has since been entirely reworked to better suit the requirements of the UserFrosting's Sprinkle system and follow the Gulp plugin guidelines (namely not unnecessarily depending on it). Though TypeScript is now the preferred language the output targeted to ES2015 and uses ES Modules (via the `esm` package) to ensure source it can be easily debugged if issues are observed in the wild.
8383

84-
This package was previously published under `gulp-uf-bundle-assets` and as of v3 is published under `@userfrosting/gulp-bundle-assets` to assist in longterm project management.
84+
This package was previously published under `gulp-uf-bundle-assets` and as of v3 is published under `@userfrosting/gulp-bundle-assets` to assist in long-term project management.
8585

8686
As of v4 virtual path logic was extracted into a separate package [@userfrosting/vinyl-fs-vpath](https://github.com/userfrosting/vinyl-fs-vpath). This change enabled a significant simplification of core logic along with a significantly faster and more efficient way to support virtual path mappings.
8787

cspell.json

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,34 @@
11
{
2-
"$schema": "https://raw.githubusercontent.com/streetsidesoftware/cspell/master/cspell.schema.json",
2+
"$schema": "https://raw.githubusercontent.com/streetsidesoftware/cspell/v5.0.1-alpha.3/cspell.schema.json",
3+
"version": "0.1",
4+
"language": "en-US",
5+
"words": [
6+
"narthollis",
7+
"Zaleski",
8+
"gregorymaertens",
9+
"Mele",
10+
"Sherland",
11+
"Soares",
12+
"jcarrivick",
13+
"bytecode",
14+
"backported"
15+
],
316
"ignoreWords": [
417
"userfrosting",
5-
"errlop"
18+
"errlop",
19+
"preversion",
20+
"postversion",
21+
"codecov",
22+
"vpath",
23+
"gulpplugin",
24+
"gulpfile"
25+
],
26+
"ignorePaths": [
27+
"cspell.json",
28+
"package-lock.json",
29+
"api-extractor.json",
30+
"docs/api/",
31+
"dist/",
32+
"temp/"
633
]
734
}

0 commit comments

Comments
 (0)