Skip to content

Commit e0f5d1b

Browse files
committed
Fix migration PHP file detection
1 parent 72fe1c0 commit e0f5d1b

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

app/sprinkles/core/src/Database/Migrator/MigrationLocator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public function getMigrations()
5656
foreach ($migrationFiles as $migrationFile) {
5757
// Note that PSR4 insists that all php files must end in PHP, so ignore all
5858
// files that don't end in PHP.
59-
if (preg_match('/php$/', $migrationFile)) {
59+
if ($migrationFile->getExtension() == 'php') {
6060
$migrations[] = $this->getMigrationDetails($migrationFile);
6161
}
6262
}

app/sprinkles/core/tests/Integration/Database/Migrator/MigrationLocatorTest.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,13 @@ public function testGetMigrations()
9090
new Resource($resourceStream, $resourceAccountLocation, 'one/CreatePasswordResetsTable.php'),
9191
new Resource($resourceStream, $resourceAccountLocation, 'two/CreateFlightsTable.php'),
9292
new Resource($resourceStream, $resourceAccountLocation, 'CreateMainTable.php'),
93-
new Resource($resourceStream, $resourceAccountLocation, 'README.md'), // This shoudn't be returned by the migrator
93+
94+
// Theses shoudn't be returned by the migrator
95+
new Resource($resourceStream, $resourceAccountLocation, 'README.md'),
96+
new Resource($resourceStream, $resourceAccountLocation, 'php.md'),
97+
new Resource($resourceStream, $resourceAccountLocation, 'foo.foophp'),
98+
new Resource($resourceStream, $resourceAccountLocation, 'blah.phpphp'),
99+
new Resource($resourceStream, $resourceAccountLocation, 'bar.phpbar'),
94100
]);
95101

96102
// Create a new MigrationLocator instance with our simulated ResourceLocation

0 commit comments

Comments
 (0)