Simplified ClassMapper->createInstance implementation

Silic0nS0ldier · Silic0nS0ldier · commit 55dd43326afe · 2019-02-16T16:23:51.000+11:00
diff --git a/app/sprinkles/core/src/Util/ClassMapper.php b/app/sprinkles/core/src/Util/ClassMapper.php
@@ -37,10 +37,7 @@ public function createInstance($identifier)
 
         $params = array_slice(func_get_args(), 1);
 
-        // We must use reflection in PHP < 5.6.  See http://stackoverflow.com/questions/8734522/dynamically-call-class-with-variable-number-of-parameters-in-the-constructor
-        $reflection = new \ReflectionClass($className);
-
-        return $reflection->newInstanceArgs($params);
+        return new $className(...$params);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -37,10 +37,7 @@ public function createInstance($identifier)`
`37`	`37`
`38`	`38`	`$params = array_slice(func_get_args(), 1);`
`39`	`39`
`40`		`- // We must use reflection in PHP < 5.6. See http://stackoverflow.com/questions/8734522/dynamically-call-class-with-variable-number-of-parameters-in-the-constructor`
`41`		`- $reflection = new \ReflectionClass($className);`
`42`		`-`
`43`		`- return $reflection->newInstanceArgs($params);`
	`40`	`+ return new $className(...$params);`
`44`	`41`	`}`
`45`	`42`
`46`	`43`	`/**`