Skip to content

Commit cedc963

Browse files
committed
fix validate generateFeaturesConfig test
1 parent efab700 commit cedc963

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

src/spec-configuration/containerFeaturesConfiguration.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ export function getContainerFeaturesBaseDockerFile(useBuildKitBuildContexts = fa
224224
225225
#{nonBuildKitFeatureContentFallback}
226226
${(() => {
227-
return useBuildKitBuildContexts ? '' : `
227+
return useBuildKitBuildContexts ? `` : `
228228
FROM $_DEV_CONTAINERS_BASE_IMAGE AS dev_containers_feature_content_normalize
229229
USER root
230230
COPY --from=dev_containers_feature_content_source {contentSourceRootPath} /tmp/build-features/
@@ -239,6 +239,7 @@ USER root
239239
${(() => {
240240
return useBuildKitBuildContexts ? `
241241
COPY --from=dev_containers_feature_content_source {contentSourceRootPath}/devcontainer-features.builtin.env /tmp/build-features/
242+
RUN chmod -R 0700 /tmp/build-features
242243
` : `
243244
COPY --from=dev_containers_feature_content_normalize /tmp/build-features /tmp/build-features
244245
`;
@@ -330,16 +331,15 @@ echo "_REMOTE_USER_HOME=$(getent passwd ${remoteUser} | cut -d: -f6)" >> /tmp/bu
330331
const folders = (featuresConfig.featureSets || []).filter(y => y.internalVersion !== '2').map(x => x.features[0].consecutiveId);
331332
folders.forEach(folder => {
332333
if (!useBuildKitBuildContexts) {
333-
result += `RUN cd /tmp/build-features/${folder} \\
334+
result += `RUN cd /tmp/build-features/${folder} \\
334335
&& chmod +x ./install.sh \\
335336
&& ./install.sh
336337
337338
`;
338339
} else {
339340
const source = path.posix.join(contentSourceRootPath, folder!);
340341
result += `RUN --mount=type=bind,from=dev_containers_feature_content_source,source=${source},target=/tmp/build-features-src/${folder} \\
341-
mkdir -p /tmp/build-feat \\
342-
&& cp -ar /tmp/build-features-src/${folder} /tmp/build-features/ \\
342+
cp -ar /tmp/build-features-src/${folder} /tmp/build-features/ \\
343343
&& cd /tmp/build-features/${folder} \\
344344
&& chmod +x ./install.sh \\
345345
&& ./install.sh \\
@@ -357,18 +357,18 @@ echo "_REMOTE_USER_HOME=$(getent passwd ${remoteUser} | cut -d: -f6)" >> /tmp/bu
357357
RUN cd /tmp/build-features/${feature.consecutiveId} \\
358358
&& chmod +x ./devcontainer-features-install.sh \\
359359
&& ./devcontainer-features-install.sh
360+
360361
`;
361362
} else {
362363
const source = path.posix.join(contentSourceRootPath, feature.consecutiveId!);
363364
result += `
364365
RUN --mount=type=bind,from=dev_containers_feature_content_source,source=${source},target=/tmp/build-features-src/${feature.consecutiveId} \\
365-
mkdir -p /tmp/build-features \\
366-
&& cp -ar /tmp/build-features-src/${feature.consecutiveId} /tmp/build-features/ \\
367-
&& chmod -R 0700 /tmp/build-features \\
366+
cp -ar /tmp/build-features-src/${feature.consecutiveId} /tmp/build-features/ \\
368367
&& cd /tmp/build-features/${feature.consecutiveId} \\
369368
&& chmod +x ./devcontainer-features-install.sh \\
370369
&& ./devcontainer-features-install.sh \\
371370
&& rm -rf /tmp/build-features/${feature.consecutiveId}
371+
372372
`;
373373
}
374374
});

0 commit comments

Comments
 (0)