fix: use SA user for MSSQL tests in CI

- Update BaseMSSQLTestCase to read DB_USER and DB_PASS from environment variables
- Update ConnectionTests and ErrorTests to use environment variables
- Simplify GitHub Actions workflow to use SA user directly (no need to create testuser)
- This avoids password policy and user creation issues in CI environment

Author: tommyknocker

.github/workflows/tests.yml

@@ -226,29 +226,17 @@ jobs:
             echo "Waiting for MSSQL... ($i/120)"
             sleep 2
           done
-      - name: Create database and user
+      - name: Create database
         run: |
           export PATH="$PATH:/opt/mssql-tools18/bin"
           # Create database (ignore error if exists)
           sqlcmd -S localhost -U sa -P 'Test123!@#' -C -Q "IF NOT EXISTS (SELECT * FROM sys.databases WHERE name = 'testdb') CREATE DATABASE testdb;" || true
-          # Drop login if exists (for clean state)
-          sqlcmd -S localhost -U sa -P 'Test123!@#' -C -Q "IF EXISTS (SELECT * FROM sys.server_principals WHERE name = 'testuser') DROP LOGIN testuser;" || true
-          # Create login with password policy disabled for testing
-          sqlcmd -S localhost -U sa -P 'Test123!@#' -C -Q "CREATE LOGIN testuser WITH PASSWORD='TestPass123!@#', CHECK_POLICY=OFF, CHECK_EXPIRATION=OFF;"
-          # Create user in database
-          sqlcmd -S localhost -U sa -P 'Test123!@#' -C -d testdb -Q "IF EXISTS (SELECT * FROM sys.database_principals WHERE name = 'testuser') DROP USER testuser;" || true
-          sqlcmd -S localhost -U sa -P 'Test123!@#' -C -d testdb -Q "CREATE USER testuser FOR LOGIN testuser;"
-          # Grant permissions
-          sqlcmd -S localhost -U sa -P 'Test123!@#' -C -d testdb -Q "ALTER ROLE db_owner ADD MEMBER testuser;"
-          # Verify user can connect
-          echo "Testing connection as testuser..."
-          sqlcmd -S localhost -U testuser -P 'TestPass123!@#' -C -d testdb -Q "SELECT USER_NAME() AS current_user, DB_NAME() AS current_database;" || (echo "Connection test failed!" && exit 1)
-          echo "User created and verified successfully!"
+          echo "Database 'testdb' ready"
       - run: composer install --no-interaction --prefer-dist
       - run: |
           DB_DSN="sqlsrv:Server=localhost,1433;Database=testdb;TrustServerCertificate=yes" \
-          DB_USER="testuser" \
-          DB_PASS="TestPass123!@#" \
+          DB_USER="sa" \
+          DB_PASS="Test123!@#" \
           vendor/bin/phpunit --testsuite="MSSQL Tests" --coverage-clover coverage-mssql.xml
       - name: Test MSSQL Examples
         run: |

tests/mssql/BaseMSSQLTestCase.php

@@ -26,14 +26,21 @@ public static function setUpBeforeClass(): void
          * USE testdb;
          * CREATE USER testuser FOR LOGIN testuser;
          * ALTER ROLE db_owner ADD MEMBER testuser;
+         * 
+         * Or use SA user for CI/testing:
+         * DB_USER=sa DB_PASS=Test123!@#
          */
+        // Use environment variables if set (for CI), otherwise use constants
+        $username = getenv('DB_USER') ?: self::DB_USER;
+        $password = getenv('DB_PASS') ?: self::DB_PASSWORD;
+        
         self::$db = new PdoDb(
             'sqlsrv',
             [
                 'host' => self::DB_HOST,
                 'port' => self::DB_PORT,
-                'username' => self::DB_USER,
-                'password' => self::DB_PASSWORD,
+                'username' => $username,
+                'password' => $password,
                 'dbname' => self::DB_NAME,
                 'trust_server_certificate' => true,
                 'encrypt' => true,

tests/mssql/ConnectionTests.php

@@ -59,11 +59,13 @@ public function testDisconnectAndPing(): void
     {
         self::$db->disconnect();
         $this->assertFalse(self::$db->ping());
+        $username = getenv('DB_USER') ?: self::DB_USER;
+        $password = getenv('DB_PASS') ?: self::DB_PASSWORD;
         self::$db = new PdoDb('sqlsrv', [
             'host' => self::DB_HOST,
             'port' => self::DB_PORT,
-            'username' => self::DB_USER,
-            'password' => self::DB_PASSWORD,
+            'username' => $username,
+            'password' => $password,
             'dbname' => self::DB_NAME,
             'trust_server_certificate' => true,
             'encrypt' => true,
@@ -73,12 +75,14 @@ public function testDisconnectAndPing(): void
 
     public function testAddConnectionAndSwitch(): void
     {
+        $username = getenv('DB_USER') ?: self::DB_USER;
+        $password = getenv('DB_PASS') ?: self::DB_PASSWORD;
         self::$db->addConnection('secondary', [
             'driver' => 'sqlsrv',
             'host' => self::DB_HOST,
             'port' => self::DB_PORT,
-            'username' => self::DB_USER,
-            'password' => self::DB_PASSWORD,
+            'username' => $username,
+            'password' => $password,
             'dbname' => self::DB_NAME,
             'trust_server_certificate' => true,
             'encrypt' => true,

tests/mssql/ErrorTests.php

@@ -25,13 +25,15 @@ public function testInvalidSqlLogsErrorAndException(): void
         $testHandler = new TestHandler();
         $logger = new Logger('test-db');
         $logger->pushHandler($testHandler);
+        $username = getenv('DB_USER') ?: self::DB_USER;
+        $password = getenv('DB_PASS') ?: self::DB_PASSWORD;
         $db = new PdoDb(
             'sqlsrv',
             [
                 'host' => self::DB_HOST,
                 'port' => self::DB_PORT,
-                'username' => self::DB_USER,
-                'password' => self::DB_PASSWORD,
+                'username' => $username,
+                'password' => $password,
                 'dbname' => self::DB_NAME,
                 'trust_server_certificate' => true,
                 'encrypt' => true,
@@ -66,13 +68,15 @@ public function testTransactionBeginCommitRollbackLogging(): void
         $testHandler = new TestHandler();
         $logger = new Logger('test-db');
         $logger->pushHandler($testHandler);
+        $username = getenv('DB_USER') ?: self::DB_USER;
+        $password = getenv('DB_PASS') ?: self::DB_PASSWORD;
         $db = new PdoDb(
             'sqlsrv',
             [
                 'host' => self::DB_HOST,
                 'port' => self::DB_PORT,
-                'username' => self::DB_USER,
-                'password' => self::DB_PASSWORD,
+                'username' => $username,
+                'password' => $password,
                 'dbname' => self::DB_NAME,
                 'trust_server_certificate' => true,
                 'encrypt' => true,