shellcheck most scripts

one thing left to do is unifying and standardizing the way the argument
string for the final call to termux-api is built.

Author: xalexalex

scripts/termux-audio-info

@@ -15,7 +15,7 @@ do
         ?) echo "$SCRIPTNAME: illegal option -$OPTARG"; exit 1;
     esac
 done
-shift $(($OPTIND-1))
+shift $((OPTIND-1))
 
 if [ $# != 0 ]; then echo "$SCRIPTNAME: too many arguments"; exit 1; fi
 

scripts/termux-battery-status

@@ -15,7 +15,7 @@ do
         ?) echo "$SCRIPTNAME: illegal option -$OPTARG"; exit 1;
     esac
 done
-shift $(($OPTIND-1))
+shift $((OPTIND-1))
 
 if [ $# != 0 ]; then echo "$SCRIPTNAME: too many arguments"; exit 1; fi
 

scripts/termux-brightness

@@ -17,7 +17,7 @@ if ! [[ $1 =~ ^([0-9]+)|auto$ ]]; then
     show_usage
 fi
 
-if [ $1 == auto ]; then
+if [ "$1" == auto ]; then
 ARGS="--ez auto true"
 else
 ARGS="--ei brightness $1 --ez auto false"

scripts/termux-call-log

@@ -24,7 +24,7 @@ do
         ?) echo "$SCRIPTNAME: illegal option -$OPTARG"; exit 1;
     esac
 done
-shift $(($OPTIND-1))
+shift $((OPTIND-1))
 
 if [ $# != 0 ]; then echo "$SCRIPTNAME: too many arguments"; exit 1; fi
 

scripts/termux-camera-info

@@ -15,7 +15,7 @@ do
         ?) echo "$SCRIPTNAME: illegal option -$OPTARG"; exit 1;
     esac
 done
-shift $(($OPTIND-1))
+shift $((OPTIND-1))
 
 if [ $# != 0 ]; then echo "$SCRIPTNAME: too many arguments"; exit 1; fi
 

scripts/termux-camera-photo

@@ -19,12 +19,12 @@ do
         ?) echo "$SCRIPTNAME: illegal option -$OPTARG"; exit 1;
     esac
 done
-shift $(($OPTIND-1))
+shift $((OPTIND-1))
 
 if [ $# = 0 ]; then echo "$SCRIPTNAME: missing file argument"; exit 1; fi
 if [ $# != 1 ]; then echo "$SCRIPTNAME: too many arguments"; exit 1; fi
 
-touch $1
+touch "$1"
 PARAMS="$PARAMS --es file `realpath $1`"
 
 /data/data/com.termux/files/usr/libexec/termux-api CameraPhoto $PARAMS

scripts/termux-clipboard-get

@@ -15,7 +15,7 @@ do
 	?) echo "$SCRIPTNAME: illegal option -$OPTARG"; exit 1;
     esac
 done
-shift $(($OPTIND-1))
+shift $((OPTIND-1))
 
 if [ $# != 0 ]; then echo "$SCRIPTNAME: too many arguments"; exit 1; fi
 

scripts/termux-clipboard-set

@@ -15,7 +15,7 @@ do
 	?) echo "$SCRIPTNAME: illegal option -$OPTARG"; exit 1;
     esac
 done
-shift $(($OPTIND-1))
+shift $((OPTIND-1))
 
 CMD="/data/data/com.termux/files/usr/libexec/termux-api Clipboard -e api_version 2 --ez set true"
 if [ $# = 0 ]; then

scripts/termux-contact-list

@@ -15,7 +15,7 @@ do
         ?) echo "$SCRIPTNAME: illegal option -$OPTARG"; exit 1;
     esac
 done
-shift $(($OPTIND-1))
+shift $((OPTIND-1))
 
 if [ $# != 0 ]; then echo "$SCRIPTNAME: too many arguments"; exit 1; fi
 

scripts/termux-dialog

@@ -142,7 +142,7 @@ list_widgets() {
     echo
 
     for w in "${widgets[@]}"; do
-        widget_usage $w
+        widget_usage "$w"
         echo
     done
 }
@@ -183,14 +183,14 @@ parse_options() {
 options_error () {
     echo -e "ERROR: Invalid option(s) detected for '$1'\n"
     echo "Usage '$1'"
-    widget_usage $1
+    widget_usage "$1"
     exit 1
 }
 
 if [ $# -eq 0 ]; then
     WIDGET=$DEFAULT_WIDGET
 # First argument wasn't a widget
-elif ! has_widget $1; then
+elif ! has_widget "$1"; then
     # we didn't receive a widget as an argument, check to see if we
     # at least options (even if they're illegal)
     if ! [[ $1 =~ -[a-z] ]]; then
@@ -211,35 +211,35 @@ case "$WIDGET" in
     # Text (default) if no widget specified
     "text")
         if [ $((FLAGS & (RANGE_FLAG | VALUES_FLAG))) -ne 0 ]; then
-            options_error $WIDGET
+            options_error "$WIDGET"
         fi
 
         if [ $((FLAGS & MULTI_LINE_FLAG)) -ne 0 ] && [ $((FLAGS & NUM_FLAG)) -ne 0 ]; then
-            options_error $WIDGET
+            options_error "$WIDGET"
         fi
         ;;
 
     "confirm")
         if [ $((FLAGS & (MULTI_LINE_FLAG | PASS_FLAG | RANGE_FLAG | VALUES_FLAG | NUM_FLAG))) -ne 0 ]; then
-            options_error $WIDGET
+            options_error "$WIDGET"
         fi
         ;;
 
     "counter")
         if [ $((FLAGS & (MULTI_LINE_FLAG | PASS_FLAG | VALUES_FLAG | NUM_FLAG))) -ne 0 ]; then
-            options_error $WIDGET
+            options_error "$WIDGET"
         fi
         ;;
 
     "speech")
         if [ $((FLAGS & (MULTI_LINE_FLAG | PASS_FLAG | RANGE_FLAG | VALUES_FLAG | NUM_FLAG))) -ne 0 ]; then
-            options_error $WIDGET
+            options_error "$WIDGET"
         fi
         ;;
 
     "date" | "time")
         if [ $((FLAGS & (HINT_FLAG | MULTI_LINE_FLAG | PASS_FLAG | RANGE_FLAG | VALUES_FLAG | NUM_FLAG))) -ne 0 ]; then
-            options_error $WIDGET
+            options_error "$WIDGET"
         fi
         ;;
 
@@ -250,7 +250,7 @@ case "$WIDGET" in
         fi
 
         if [ $((FLAGS & (HINT_FLAG | MULTI_LINE_FLAG | PASS_FLAG | RANGE_FLAG | NUM_FLAG))) -ne 0 ]; then
-            options_error $WIDGET
+            options_error "$WIDGET"
         fi
         ;;