Skip to content

Commit 175bcc8

Browse files
joyeecheungtargos
authored andcommitted
deps: V8: cherry-pick 4f9f652d6d4d
Original commit message: Add missing #include <memory> to bigint.h bigint.h declares std::unique_ptr members in the Processor class but does not include <memory>. This compiled incidentally because a transitive include was pulling in <memory> as a side effect. With recent changes to the include chain, the transitive dependency is no longer present, causing build failures when compiling with libstdc++: bigint.h: error: no template named 'unique_ptr' in namespace 'std' Fix by adding the direct include that bigint.h requires. Refs: nodejs#62572 Change-Id: I8d43a9f77151a3a5b8caa7f271a16f19007c767b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7726130 Commit-Queue: Joyee Cheung <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/main@{#106355} Refs: v8/v8@4f9f652
1 parent bbacdb3 commit 175bcc8

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.9',
41+
'v8_embedder_string': '-node.10',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/src/bigint/bigint.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <algorithm>
1111
#include <cstring>
1212
#include <iostream>
13+
#include <memory>
1314
#include <utility>
1415

1516
namespace v8 {

0 commit comments

Comments
 (0)