Skip to content

Commit 7f9beab

Browse files
authored
Make IWICBitmapSourceProtocol public (underscored) to suppress new compiler warning. (#1484)
This PR renames `IWICBitmapSourceProtocol` to `_IWICBitmapSourceProtocol` and makes it `public` in order to silence warnings generated by swiftlang/swift#86279. Namely: ``` 43 | extension IWICFormatConverter: _AttachableByAddressAsIWICBitmapSource, IWICBitmapSourceProtocol {} | `- warning: method '_copyAttachableValue(at:)' must be as accessible as its enclosing type because it matches a requirement in protocol '_AttachableByAddressAsIWICBitmapSource' 89 | public static func _copyAttachableValue(at imageAddress: UnsafeMutablePointer<Self>) -> UnsafeMutablePointer<Self> { | `- note: mark the static method as 'public' to satisfy the requirement ``` ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
1 parent 6da5baa commit 7f9beab

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

Sources/Overlays/_Testing_WinSDK/Attachments/IWICBitmapSource+AttachableAsIWICBitmapSource.swift

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,21 +31,21 @@ public import WinSDK
3131
///
3232
/// This protocol is not part of the public interface of the testing library. It
3333
/// allows us to reuse code across all subclasses of `IWICBitmapSource`.
34-
protocol IWICBitmapSourceProtocol: _AttachableByAddressAsIWICBitmapSource {}
34+
public protocol _IWICBitmapSourceProtocol: _AttachableByAddressAsIWICBitmapSource {}
3535

36-
extension IWICBitmapSource: _AttachableByAddressAsIWICBitmapSource, IWICBitmapSourceProtocol {}
37-
extension IWICBitmap: _AttachableByAddressAsIWICBitmapSource, IWICBitmapSourceProtocol {}
38-
extension IWICBitmapClipper: _AttachableByAddressAsIWICBitmapSource, IWICBitmapSourceProtocol {}
39-
extension IWICBitmapFlipRotator: _AttachableByAddressAsIWICBitmapSource, IWICBitmapSourceProtocol {}
40-
extension IWICBitmapFrameDecode: _AttachableByAddressAsIWICBitmapSource, IWICBitmapSourceProtocol {}
41-
extension IWICBitmapScaler: _AttachableByAddressAsIWICBitmapSource, IWICBitmapSourceProtocol {}
42-
extension IWICColorTransform: _AttachableByAddressAsIWICBitmapSource, IWICBitmapSourceProtocol {}
43-
extension IWICFormatConverter: _AttachableByAddressAsIWICBitmapSource, IWICBitmapSourceProtocol {}
44-
extension IWICPlanarFormatConverter: _AttachableByAddressAsIWICBitmapSource, IWICBitmapSourceProtocol {}
36+
extension IWICBitmapSource: _AttachableByAddressAsIWICBitmapSource, _IWICBitmapSourceProtocol {}
37+
extension IWICBitmap: _AttachableByAddressAsIWICBitmapSource, _IWICBitmapSourceProtocol {}
38+
extension IWICBitmapClipper: _AttachableByAddressAsIWICBitmapSource, _IWICBitmapSourceProtocol {}
39+
extension IWICBitmapFlipRotator: _AttachableByAddressAsIWICBitmapSource, _IWICBitmapSourceProtocol {}
40+
extension IWICBitmapFrameDecode: _AttachableByAddressAsIWICBitmapSource, _IWICBitmapSourceProtocol {}
41+
extension IWICBitmapScaler: _AttachableByAddressAsIWICBitmapSource, _IWICBitmapSourceProtocol {}
42+
extension IWICColorTransform: _AttachableByAddressAsIWICBitmapSource, _IWICBitmapSourceProtocol {}
43+
extension IWICFormatConverter: _AttachableByAddressAsIWICBitmapSource, _IWICBitmapSourceProtocol {}
44+
extension IWICPlanarFormatConverter: _AttachableByAddressAsIWICBitmapSource, _IWICBitmapSourceProtocol {}
4545

4646
// MARK: - Upcasting conveniences
4747

48-
extension UnsafeMutablePointer where Pointee: IWICBitmapSourceProtocol {
48+
extension UnsafeMutablePointer where Pointee: _IWICBitmapSourceProtocol {
4949
/// Upcast this WIC bitmap to a WIC bitmap source (its parent type).
5050
///
5151
/// - Returns: `self`, cast to the parent type via `QueryInterface()`. The
@@ -78,7 +78,7 @@ extension UnsafeMutablePointer where Pointee: IWICBitmapSourceProtocol {
7878

7979
// MARK: - _AttachableByAddressAsIWICBitmapSource implementation
8080

81-
extension IWICBitmapSourceProtocol {
81+
extension _IWICBitmapSourceProtocol {
8282
public static func _copyAttachableIWICBitmapSource(
8383
from imageAddress: UnsafeMutablePointer<Self>,
8484
using factory: UnsafeMutablePointer<IWICImagingFactory>

0 commit comments

Comments
 (0)