perf: don't enforce path mapping with dummy function by default

Author: sudo-tee

lua/opencode/api_client.lua

@@ -3,27 +3,7 @@ local state = require('opencode.state')
 local url_encode = require('opencode.util').url_encode
 local apply_path_map = require('opencode.util').apply_path_map
 local reverse_transform_paths_recursive = require('opencode.util').reverse_transform_paths_recursive
-
---- Transform file paths in API payloads using configured path_map
---- @param data any The data to transform (table, string, or other)
---- @return any transformed_data The data with paths transformed
-local function transform_paths_recursive(data)
-  if type(data) ~= 'table' then
-    return data
-  end
-
-  local result = {}
-  for key, value in pairs(data) do
-    if type(value) == 'string' and (key == 'filePath' or key == 'path' or key == 'directory') then
-      result[key] = apply_path_map(value)
-    elseif type(value) == 'table' then
-      result[key] = transform_paths_recursive(value)
-    else
-      result[key] = value
-    end
-  end
-  return result
-end
+local transform_paths_recursive = require('opencode.util').transform_paths_recursive
 
 --- @class OpencodeApiClient
 --- @field base_url string The base URL of the opencode server
@@ -52,8 +32,6 @@ function OpencodeApiClient:_ensure_base_url()
     return true
   end
 
-  local state = require('opencode.state')
-
   if not state.opencode_server then
     -- this is last resort - try to start the server and could be blocking
     state.opencode_server = server_job.ensure_server():wait() --[[@as OpencodeServer]]

lua/opencode/config.lua

@@ -21,12 +21,8 @@ M.defaults = {
     spawn_command = nil,
     kill_command = nil,
     auto_kill = true,
-    path_map = function(path)
-      return path
-    end,
-    reverse_path_map = function(path)
-      return path
-    end,
+    path_map = nil,
+    reverse_path_map = nil,
   },
   keymap = {
     editor = {

lua/opencode/util.lua

@@ -98,7 +98,9 @@ end
 --- @param str string The string to encode
 --- @return string encoded_string The URL-encoded string
 function M.url_encode(str)
-  if not str then return '' end
+  if not str then
+    return ''
+  end
   str = tostring(str)
   str = string.gsub(str, '\n', '\r\n')
   str = string.gsub(str, '([^%w%-%.%_%~])', function(c)
@@ -114,10 +116,10 @@ function M.apply_path_map(path)
   if not path then
     return path
   end
-  
+
   local config = require('opencode.config')
   local path_map = config.server.path_map
-  
+
   if type(path_map) == 'function' then
     local ok, result = pcall(path_map, path)
     if ok and result then
@@ -134,44 +136,46 @@ function M.apply_path_map(path)
       return path_map .. relative_path
     end
   end
-  
+
   return path
 end
 
 function M.apply_reverse_path_map(path)
   if not path then
     return path
   end
-  
+
   local config = require('opencode.config')
   local reverse_path_map = config.server.reverse_path_map
-  
+
   if type(reverse_path_map) == 'function' then
     local ok, result = pcall(reverse_path_map, path)
     if ok and result then
       return result
     end
     return path
   end
-  
+
   return path
 end
 
 function M.reverse_transform_paths_recursive(data)
+  local config = require('opencode.config')
+  local reverse_path_map = config.server.reverse_path_map
+  if not reverse_path_map or type(reverse_path_map) ~= 'function' then
+    return data
+  end
+
   if type(data) ~= 'table' then
     return data
   end
 
   local result = {}
   for key, value in pairs(data) do
-    if type(value) == 'string' and (
-      key == 'filePath' or 
-      key == 'path' or 
-      key == 'file' or
-      key == 'directory' or
-      key == 'cwd' or
-      key == 'root'
-    ) then
+    if
+      type(value) == 'string'
+      and (key == 'filePath' or key == 'path' or key == 'file' or key == 'directory' or key == 'cwd' or key == 'root')
+    then
       result[key] = M.apply_reverse_path_map(value)
     elseif type(value) == 'table' and (key == 'files' or key == 'deleted_files') then
       result[key] = vim.tbl_map(M.apply_reverse_path_map, value)
@@ -184,6 +188,33 @@ function M.reverse_transform_paths_recursive(data)
   return result
 end
 
+--- Transform file paths in API payloads using configured path_map
+--- @param data any The data to transform (table, string, or other)
+--- @return any transformed_data The data with paths transformed
+function M.transform_paths_recursive(data)
+  local config = require('opencode.config')
+  local path_map = config.server.path_map
+  if not path_map or type(path_map) ~= 'function' then
+    return data
+  end
+
+  if type(data) ~= 'table' then
+    return data
+  end
+
+  local result = {}
+  for key, value in pairs(data) do
+    if type(value) == 'string' and (key == 'filePath' or key == 'path' or key == 'directory') then
+      result[key] = M.apply_path_map(value)
+    elseif type(value) == 'table' then
+      result[key] = M.transform_paths_recursive(value)
+    else
+      result[key] = value
+    end
+  end
+  return result
+end
+
 --- Format a timestamp as time (e.g., "10:23 AM",  "13 Oct 03:32 PM"  "13 Oct 2025 03:32 PM")
 --- @param timestamp number
 --- @return string: Formatted time string