sudoers_policy_list: do not set runas_pw to list_pw when listing

millert · millert · commit ef7cc6ed06df · 2023-03-03T11:16:44.000-07:00
This change introduced in sudo 1.9.13 is not actually needed. The "list" pseudo-command checks are performed via runas_matches_pw() which does not use runas_pw. GitHub issue #248 --HG-- branch : 1.9
diff --git a/plugins/sudoers/policy.c b/plugins/sudoers/policy.c
@@ -1270,11 +1270,6 @@ sudoers_policy_list(int argc, char * const argv[], int verbose,
 	    sudo_warnx(U_("unknown user %s"), list_user);
 	    debug_return_int(-1);
 	}
-	/* A user may only list another user they have runas access to. */
-	if (runas_pw != NULL)
-	    sudo_pw_delref(runas_pw);
-	runas_pw = list_pw;
-	sudo_pw_addref(list_pw);
     }
     ret = sudoers_policy_main(argc, argv, I_LISTPW, NULL, verbose, NULL);
     if (list_user) {

Original file line number	Diff line number	Diff line change
`@@ -1270,11 +1270,6 @@ sudoers_policy_list(int argc, char * const argv[], int verbose,`
`1270`	`1270`	`sudo_warnx(U_("unknown user %s"), list_user);`
`1271`	`1271`	`debug_return_int(-1);`
`1272`	`1272`	`}`
`1273`		`- /* A user may only list another user they have runas access to. */`
`1274`		`- if (runas_pw != NULL)`
`1275`		`- sudo_pw_delref(runas_pw);`
`1276`		`- runas_pw = list_pw;`
`1277`		`- sudo_pw_addref(list_pw);`
`1278`	`1273`	`}`
`1279`	`1274`	`ret = sudoers_policy_main(argc, argv, I_LISTPW, NULL, verbose, NULL);`
`1280`	`1275`	`if (list_user) {`