Fix exception from invisible JBMenuItem (#53)

Author: mohamead

CHANGELOG.md

@@ -4,6 +4,15 @@
 
 ## [Unreleased]
 
+## [0.0.4] - 2025.07.10
+
+### What's Changed
+* Update changelog.md by @mohamead in [PR #51](https://github.com/statens-pensjonskasse/fiskeoye-plugin/pull/51)
+* Add vertical scrollbar when needed by @mohamead in [PR #52](https://github.com/statens-pensjonskasse/fiskeoye-plugin/pull/52)
+* Fix exception from invisible JBMenuItem in [PR #53](https://github.com/statens-pensjonskasse/fiskeoye-plugin/pull/53)
+
+**Full Changelog**: https://github.com/statens-pensjonskasse/fiskeoye-plugin/compare/v0.0.3...v0.0.4
+
 ## [0.0.3] - 2025.07.02
 
 ### What's Changed

src/main/kotlin/no/spk/fiskeoye/plugin/listeners/button/FileContentSearchListener.kt

@@ -88,8 +88,6 @@ internal class FileContentSearchListener(private val fileContentPanel: FileConte
     ) {
         SwingUtilities.invokeLater {
             val headerText = buildHeaderText(searchText, searchParams, elements.size)
-            logger.info(headerText)
-
             val model = buildTableModel(headerText, elements)
 
             fileContentPanel.apply {

src/main/kotlin/no/spk/fiskeoye/plugin/ui/FileContentPanel.kt

@@ -37,7 +37,7 @@ internal class FileContentPanel : FiskeoyePanel() {
         this.caseSensitiveButton = buildCaseSensitiveButton()
         this.urlLabel = buildUrlLabel()
 
-        val searchButton = buildSeachButton(FileContentSearchListener(this))
+        val searchButton = buildSearchButton(FileContentSearchListener(this))
         val clearButton = buildClearButton(FileContentClearListener(this))
 
         val defaultActionGroup = DefaultActionGroup().apply {

src/main/kotlin/no/spk/fiskeoye/plugin/ui/FilenamePanel.kt

@@ -35,7 +35,7 @@ internal class FilenamePanel : FiskeoyePanel() {
         }
         this.urlLabel = buildUrlLabel()
 
-        val searchButton = buildSeachButton(FilenameSearchListener(this))
+        val searchButton = buildSearchButton(FilenameSearchListener(this))
         val clearButton = buildClearButton(FilenameClearListener(this))
 
         val defaultActionGroup = DefaultActionGroup().apply {

src/main/kotlin/no/spk/fiskeoye/plugin/ui/FiskeoyePanel.kt

@@ -36,6 +36,7 @@ import java.awt.Dimension
 import java.awt.Font
 import java.awt.event.KeyListener
 import javax.swing.JButton
+import javax.swing.JTable.AUTO_RESIZE_OFF
 import javax.swing.JToggleButton
 import javax.swing.ListSelectionModel
 import javax.swing.ScrollPaneConstants.HORIZONTAL_SCROLLBAR_AS_NEEDED
@@ -72,6 +73,7 @@ internal abstract class FiskeoyePanel : SimpleToolWindowPanel(true, true), DumbA
             componentPopupMenu = buildPopupMenu(this)
             font = buildFont()
             autoscrolls = false
+            autoResizeMode = AUTO_RESIZE_OFF
             setDefaultRenderer(LabelIcon::class.java, LabelIconRenderer())
             setSelectionMode(ListSelectionModel.SINGLE_INTERVAL_SELECTION)
             setShowGrid(false)
@@ -97,25 +99,30 @@ internal abstract class FiskeoyePanel : SimpleToolWindowPanel(true, true), DumbA
 
     private fun buildPopupMenu(table: JBTable): JBPopupMenu {
         return JBPopupMenu().apply popupMenu@{
-            val copyLink = buildCopyLink(table)
-            this.add(copyLink)
-            val copyLinkForMarkdown = buildCopyLinkForMarkdown(table)
-            this.add(copyLinkForMarkdown)
-            val copyLinkForJira = buildCopyLinkForJira(table)
-            this.add(copyLinkForJira)
-            val nothingHere = JBMenuItem("Nothing here")
-            this.add(nothingHere)
-
             this.addPopupMenuListener(object : PopupMenuListenerAdapter() {
                 override fun popupMenuWillBecomeVisible(e: PopupMenuEvent?) {
-                    val tableIsValid = (!table.isEmpty && table.model.getValueAt(table.selectedRow, 1) != null)
-                    copyLink.isVisible = tableIsValid
-                    copyLinkForMarkdown.isVisible = tableIsValid
-                    copyLinkForJira.isVisible = tableIsValid
-                    nothingHere.isVisible = !tableIsValid
+                    removeAll()
+                    val isValid = try {
+                        val isNotEmpty = !table.isEmpty
+                        val hasData = table.selectedRow >= 0 && table.selectedRow < table.rowCount
+                        val isNotNull = table.model.getValueAt(table.selectedRow, 1) != null
+                        isNotNull && hasData && isNotEmpty
+                    } catch (e: Exception) {
+                        false
+                    }
+                    if (!isValid) {
+                        val nothingHere = JBMenuItem("Nothing here")
+                        add(nothingHere)
+                        return
+                    }
+                    val copyLink = buildCopyLink(table)
+                    add(copyLink)
+                    val copyLinkForMarkdown = buildCopyLinkForMarkdown(table)
+                    add(copyLinkForMarkdown)
+                    val copyLinkForJira = buildCopyLinkForJira(table)
+                    add(copyLinkForJira)
                 }
             })
-
         }
     }
 
@@ -174,7 +181,7 @@ internal abstract class FiskeoyePanel : SimpleToolWindowPanel(true, true), DumbA
     }
 
     @Suppress("UnstableApiUsage")
-    protected fun buildSeachButton(fiskeoyeActionListener: FiskeoyeActionListener): JButton {
+    protected fun buildSearchButton(fiskeoyeActionListener: FiskeoyeActionListener): JButton {
         return JButton().apply {
             defaultButton()
             text = "Search"

src/main/kotlin/no/spk/fiskeoye/plugin/util/FiskeoyeUtil.kt

@@ -29,7 +29,6 @@ import java.net.URL
 import javax.swing.JEditorPane
 import javax.swing.JTable.AUTO_RESIZE_ALL_COLUMNS
 import javax.swing.JTable.AUTO_RESIZE_OFF
-import javax.swing.JTable.AUTO_RESIZE_SUBSEQUENT_COLUMNS
 import javax.swing.table.DefaultTableModel
 import javax.swing.text.html.HTMLEditorKit
 
@@ -105,12 +104,14 @@ internal fun openUrlWithBrowser(uri: URI) {
 
 internal fun JBTable.clear() {
     this.model = DefaultTableModel()
+    this.autoResizeMode = AUTO_RESIZE_OFF
     this.preferredSize = Dimension(0, 0)
 }
 
 internal fun JBTable.addMessage(message: String) {
     this.apply {
         clear()
+        autoResizeMode = AUTO_RESIZE_ALL_COLUMNS
         model = getDefaultModel(message)
         hideColumns()
     }
@@ -213,18 +214,18 @@ internal fun getDefaultModel(header: String): DefaultTableModel {
 }
 
 internal fun getTruckMessage(maxSize: Int): String {
-    return getHtmlError("NB! Antall treff overstiger $maxSize. Resultatet er trunkert")
+    return getError("NB! Antall treff overstiger $maxSize. Resultatet er trunkert")
 }
 
 internal fun getGeneralErrorMessage(): String {
-    return getHtmlError("Ops! Ser ut som noe gikk galt! Se \"${LoggerFactory.getLogFilePath()}\" for mer info...")
+    return getHtml(getError("Ops! Ser ut som noe gikk galt! Se \"${LoggerFactory.getLogFilePath()}\" for mer info..."))
 }
 
 internal fun getInvalidString(): String {
-    return getHtmlError("Søkestrengen må være på minst tre tegn.")
+    return getHtml(getError("Søkestrengen må være på minst tre tegn."))
 }
 
-internal fun getHtmlError(value: String): String {
+internal fun getError(value: String): String {
     return "<span style=\"color:red;\">$value<span>"
 }