Unchecked access of disablePageSizeChange

[DallasHoff]

Tried updating from 3.50.4-build1 to 3.51.2-build5 today. When attempting to use the KVVFS, SQLite WASM throws xFileControl [TypeError: Cannot read properties of undefined (reading 'disablePageSizeChange')]. If I edit the library's use of kvvfs.internal.disablePageSizeChange to kvvfs.internal?.disablePageSizeChange, all my tests pass, so the logic that reads disablePageSizeChange needs to be patched somehow, if not simply like this.

[jurerotar]

I can't help with this one, because it seems to be coming from upstream. :(

What I can do though, is create a test suite to make sure we catch this in the future. Since I don't use KVVFS API, could you check please #147, and if possible, add more test cases for features that I missed and you're more familiar with 😄

[sgbeal]

Thank you for the report - i'll get that resolved today. You shouldn't need the patch you applied, but it is also harmless for the time being.

[sgbeal]

Fixed in https://sqlite.org/src/info/407724c4e8:

-              && kvvfs.internal.disablePageSizeChange ){
+              && kvvfsInternal.disablePageSizeChange ){

The symbol kvvfs.internal is only set when running kvvfs knows that it's running in a test build. kvvfsInternal, on the other hand, is scoped to that file regardless of test/non-test mode.

[tomayac]

Closing as fixed upstream. Thanks all!

[DallasHoff]

Yes, thank you all :)