Follow Dockerfile guideline (#2003)

* Follow Dockerfile guideline

* Fix a bug

* Silence go get

Author: wangkuiyi

elasticdl/docker/Dockerfile

@@ -15,14 +15,15 @@ ARG EXTRA_PYPI_INDEX=https://pypi.org/simple
 RUN apt-get -qq update && \
     apt-get -qq install -y unzip curl git software-properties-common g++ wget \
                        libeigen3-dev > /dev/null && \
-    python -m pip install --upgrade pip
+    python -m pip install --quiet --upgrade pip
 
 COPY elasticdl/requirements.txt /requirements.txt
-RUN python -m pip -q install -r /requirements.txt \
+RUN python -m pip install --quiet -r /requirements.txt \
         --extra-index-url=$EXTRA_PYPI_INDEX \
-    && rm /requirements.txt
+        && rm /requirements.txt
+
 COPY elasticdl/requirements-dev.txt /requirements-dev.txt
-RUN python -m pip -q install -r /requirements-dev.txt \
+RUN python -m pip install --quiet -r /requirements-dev.txt \
         --extra-index-url=$EXTRA_PYPI_INDEX \
     && rm /requirements-dev.txt
 
@@ -78,7 +79,7 @@ RUN cd /elasticdl && \
 
 # Create elasticdl package
 RUN cd /elasticdl && \
-    python setup.py -q bdist_wheel && \
+    python setup.py --quiet bdist_wheel && \
     cp dist/elasticdl-develop-py3-none-any.whl /
 
 
@@ -88,14 +89,14 @@ FROM ${BASE_IMAGE} as ci
 ARG EXTRA_PYPI_INDEX=https://pypi.org/simple
 
 COPY elasticdl/docker/bashrc /etc/bash.bashrc
-RUN chmod a+rwx /etc/bash.bashrc
+RUN chmod a+rx /etc/bash.bashrc
 
 # Copy data
 COPY --from=dev /data /data
 
 # Copy model zoo
 COPY model_zoo /model_zoo
-RUN python -m pip -q install -r /model_zoo/requirements.txt \
+RUN python -m pip install --quiet -r /model_zoo/requirements.txt \
         --extra-index-url=${EXTRA_PYPI_INDEX}
 
 # Copy GO PS
@@ -108,7 +109,7 @@ WORKDIR /
 
 # Install elasticdl package
 COPY --from=dev /elasticdl-develop-py3-none-any.whl /
-RUN python -m pip -q install /elasticdl-develop-py3-none-any.whl \
+RUN python -m pip install --quiet /elasticdl-develop-py3-none-any.whl \
         --extra-index-url=${EXTRA_PYPI_INDEX} \
     && rm /elasticdl-develop-py3-none-any.whl
 

elasticdl/docker/Dockerfile.dev_allreduce

@@ -3,12 +3,12 @@ FROM elasticdl:dev
 WORKDIR /root/
 
 # Note that pip is having issue downloading PyTorch on manylinux so we use curl to download it instead
-RUN curl -o torch-1.4.0-cp36-cp36m-manylinux1_x86_64.whl \
+RUN curl -sLo torch-1.4.0-cp36-cp36m-manylinux1_x86_64.whl \
   https://files.pythonhosted.org/packages/24/19/4804aea17cd136f1705a5e98a00618cb8f6ccc375ad8bfa437408e09d058/torch-1.4.0-cp36-cp36m-manylinux1_x86_64.whl
-RUN pip install torch-1.4.0-cp36-cp36m-manylinux1_x86_64.whl && \
+RUN python -m pip install --quiet torch-1.4.0-cp36-cp36m-manylinux1_x86_64.whl && \
   rm torch-1.4.0-cp36-cp36m-manylinux1_x86_64.whl
 
 RUN git clone --depth=1 https://github.com/caicloud/ftlib.git
-RUN cd /root/ftlib && pip install -r requirements.txt
+RUN cd /root/ftlib && python -m pip install --quiet -r requirements.txt
 RUN cd /root/ftlib/ftlib/consensus/gossip && bash ./gen_shared_lib.sh
 RUN cp -r /root/ftlib/ftlib /usr/local/lib/python3.6/dist-packages/ftlib

elasticdl/docker/scripts/install-go.bash

@@ -4,16 +4,17 @@ set -e
 
 GO_MIRROR_URL=$1
 
-curl --silent ${GO_MIRROR_URL}/go1.13.4.linux-amd64.tar.gz | tar -C /usr/local -xzf -
+curl --silent "$GO_MIRROR_URL"/go1.13.4.linux-amd64.tar.gz | \
+    tar -C /usr/local -xzf -
 
 go env -w GO111MODULE=on
 go env -w GOPROXY=https://goproxy.io,direct
 
-go get github.com/golang/protobuf/[email protected]
-go get golang.org/x/lint/golint
-go get golang.org/x/tools/cmd/goyacc
-go get golang.org/x/tools/cmd/cover
-go get github.com/mattn/goveralls
-go get github.com/rakyll/gotest
+go get github.com/golang/protobuf/[email protected] > /dev/null
+go get golang.org/x/lint/golint > /dev/null
+go get golang.org/x/tools/cmd/goyacc > /dev/null
+go get golang.org/x/tools/cmd/cover > /dev/null
+go get github.com/mattn/goveralls > /dev/null
+go get github.com/rakyll/gotest > /dev/null
 
-cp $GOPATH/bin/* /usr/local/bin/
+cp "$GOPATH"/bin/* /usr/local/bin/