Merge pull request #815 from gjorgievskivlatko/enable-empty-filter-property

bnasslahsen · web-flow · commit e848e9f63a0f · 2020-08-06T21:04:27.000+02:00
Allow swagger-ui property filter to be an empty string
diff --git a/springdoc-openapi-common/src/main/java/org/springdoc/ui/AbstractSwaggerWelcome.java b/springdoc-openapi-common/src/main/java/org/springdoc/ui/AbstractSwaggerWelcome.java
@@ -139,8 +139,9 @@ protected UriComponentsBuilder getUriComponentsBuilder(String sbUrl) {
 			uriBuilder.queryParam(SwaggerUiConfigParameters.CONFIG_URL_PROPERTY, swaggerUiConfigParameters.getConfigUrl());
 			if (StringUtils.isNotEmpty(swaggerUiConfigParameters.getLayout()))
 				uriBuilder.queryParam(SwaggerUiConfigParameters.LAYOUT_PROPERTY, swaggerUiConfigParameters.getLayout());
-			if (StringUtils.isNotEmpty(swaggerUiConfigParameters.getFilter()))
+			if (swaggerUiConfigParameters.getFilter() != null) {
 				uriBuilder.queryParam(SwaggerUiConfigParameters.FILTER_PROPERTY, swaggerUiConfigParameters.getFilter());
+			}
 		}
 		return uriBuilder;
 	}

Original file line number	Diff line number	Diff line change
`@@ -139,8 +139,9 @@ protected UriComponentsBuilder getUriComponentsBuilder(String sbUrl) {`
`139`	`139`	`uriBuilder.queryParam(SwaggerUiConfigParameters.CONFIG_URL_PROPERTY, swaggerUiConfigParameters.getConfigUrl());`
`140`	`140`	`if (StringUtils.isNotEmpty(swaggerUiConfigParameters.getLayout()))`
`141`	`141`	`uriBuilder.queryParam(SwaggerUiConfigParameters.LAYOUT_PROPERTY, swaggerUiConfigParameters.getLayout());`
`142`		`- if (StringUtils.isNotEmpty(swaggerUiConfigParameters.getFilter()))`
	`142`	`+ if (swaggerUiConfigParameters.getFilter() != null) {`
`143`	`143`	`uriBuilder.queryParam(SwaggerUiConfigParameters.FILTER_PROPERTY, swaggerUiConfigParameters.getFilter());`
	`144`	`+ }`
`144`	`145`	`}`
`145`	`146`	`return uriBuilder;`
`146`	`147`	`}`