From 88ecbb18ce55ee0ba1062567e1f02fd8b05c428b Mon Sep 17 00:00:00 2001 From: Krzysztof Ligarski Date: Thu, 20 Mar 2025 14:33:13 +0100 Subject: [PATCH] add support for pageSheet --- .../swmansion/rnscreens/ScreenViewManager.kt | 2 +- apps/src/screens/Modals.tsx | 14 ++++++++++ apps/src/screens/StackPresentation.tsx | 27 +++++++++++++++++++ guides/GUIDE_FOR_LIBRARY_AUTHORS.md | 4 ++- ios/RNSConvert.mm | 2 ++ ios/RNSEnums.h | 3 ++- ios/RNSScreen.mm | 10 +++++++ native-stack/README.md | 1 + src/fabric/ModalScreenNativeComponent.ts | 1 + src/fabric/ScreenNativeComponent.ts | 1 + src/native-stack/types.tsx | 1 + .../utils/getDefaultHeaderHeight.tsx | 6 +++-- src/types.tsx | 4 ++- 13 files changed, 70 insertions(+), 6 deletions(-) diff --git a/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt b/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt index 3889c2f362..3c655d369f 100644 --- a/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt +++ b/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt @@ -126,7 +126,7 @@ open class ScreenViewManager : when (presentation) { "push" -> Screen.StackPresentation.PUSH "formSheet" -> Screen.StackPresentation.FORM_SHEET - "modal", "containedModal", "fullScreenModal" -> + "modal", "containedModal", "fullScreenModal", "pageSheet" -> Screen.StackPresentation.MODAL "transparentModal", "containedTransparentModal" -> Screen.StackPresentation.TRANSPARENT_MODAL diff --git a/apps/src/screens/Modals.tsx b/apps/src/screens/Modals.tsx index 3d50f4a6d7..5e4727f033 100644 --- a/apps/src/screens/Modals.tsx +++ b/apps/src/screens/Modals.tsx @@ -12,6 +12,7 @@ type StackParamList = { FullscreenModal: undefined; Alert: undefined; ContainedModal: undefined; + PageSheet: undefined; }; interface MainScreenProps { @@ -30,6 +31,10 @@ const MainScreen = ({ navigation }: MainScreenProps): React.JSX.Element => ( title="Open contained modal" onPress={() => navigation.navigate('ContainedModal')} /> +