Commit 65f6e92
authored
fix(CI): change order of events in Fabric iOS events e2e test (#2785)
## Description
Changed order of events in Fabric iOS events e2e test.
The order of events in this test differs from the Paper version of the
same test. When screen is removed after using iOS native back button,
native side notifies JS via:
1. onDismissed => in reaction to this event, a navigation action is
dispatched, which causes emission of beforeRemove event;
2. onDisappear => in reaction to this event, transitionEnd with
closing=true is emitted.
On Fabric, these events are handled in the same order as the order of
notifications from the native side. On Paper, this is not the case -
onDismissed is executed after two transitionEnd events are already
handled. onDismissed is dispatched asynchronously from the native side
(it is wrapped in `dispatch_async`!) and this probably delays handling
it on JS side but I am not sure of the details why it is dispatched
asynchronously.
Currently this divergence between architectures seems to not lead to any
issues. Just let it be noted & not forgotten.
## Changes
- change order of assertions
- add comment with explanation
## Test code and steps to reproduce
Run Fabric iOS CI.
## Checklist
- [x] Ensured that CI for Fabric iOS passes1 parent e59f5fc commit 65f6e92
1 file changed
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| 26 | + | |
| 27 | + | |
24 | 28 | | |
25 | | - | |
| 29 | + | |
26 | 30 | | |
27 | 31 | | |
28 | | - | |
| 32 | + | |
29 | 33 | | |
30 | | - | |
31 | | - | |
32 | 34 | | |
33 | 35 | | |
34 | 36 | | |
| |||
0 commit comments