Error Handling including spec for wrong ID-Hashes

Author: schilbach

evaluationserver/app/controllers/experiments_controller.rb

@@ -80,6 +80,12 @@ def start
   end
 
   def conduct
+    if @participant_experiment_step.nil?
+      render :layout => 'blank', :status => :error, :text => 'No such step'
+      return
+    end
+
+    
     unless @participant_experiment_step.experiment_step.step.scenes.empty?
 
 

evaluationserver/spec/controllers/experiments_controller_spec.rb

@@ -1,5 +1,11 @@
 require 'rails_helper'
 
 RSpec.describe ExperimentsController, type: :controller do
-
+  describe "GET conduct" do
+    it "Raises controlled error on wrong experiment" do
+      @experiment = create(:experiment_with_static_text)
+      get 'conduct', :params => {:id_hash => @experiment.id_hash} ## this is the wrong type of hash
+      expect(response).to have_http_status(:error)
+    end
+  end
 end