Skip to content

Commit bebf3f4

Browse files
committed
Remove bootstrap dev dependency
1 parent cc9fce6 commit bebf3f4

13 files changed

Lines changed: 28 additions & 43 deletions

dev/App.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,13 @@ export const App: FC = () => {
4040

4141
return (
4242
<>
43-
<header className={clsx(
44-
'tw:h-(--header-height) tw:fixed tw:top-0 tw:left-0 tw:right-0 tw:flex tw:justify-between',
45-
'tw:bg-lm-main tw:dark:bg-dm-main tw:text-white',
46-
)}>
43+
<header
44+
className={clsx(
45+
'tw:fixed tw:top-0 tw:left-0 tw:right-0 tw:z-1000',
46+
'tw:h-(--header-height) tw:flex tw:justify-between',
47+
'tw:bg-lm-main tw:dark:bg-dm-main tw:text-white',
48+
)}
49+
>
4750
<ServerInfoForm serverInfo={serverInfo} onChange={onServerInfoChange} />
4851
<div className="tw:h-full tw:pr-4 tw:flex tw:items-center tw:gap-4">
4952
<Link to="/" className="tw:text-white">Home</Link>

dev/index.scss

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
11
@use '../node_modules/@shlinkio/shlink-frontend-kit/dist/base';
2-
@use '../node_modules/bootstrap/scss/bootstrap.scss' with (
3-
$primary: base.$mainColor
4-
);
52
@use '../node_modules/@shlinkio/shlink-frontend-kit/dist/index';
63
@use '../src/index.scss' as dev-index;

package-lock.json

Lines changed: 4 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"@fortawesome/free-solid-svg-icons": "^6.7.2",
4747
"@fortawesome/react-fontawesome": "^0.2.2",
4848
"@reduxjs/toolkit": "^2.5.0",
49-
"@shlinkio/shlink-frontend-kit": "^0.9.9",
49+
"@shlinkio/shlink-frontend-kit": "^0.9.10",
5050
"@shlinkio/shlink-js-sdk": "^2.0.0",
5151
"react": "^18.3 || ^19.0",
5252
"react-dom": "^18.3 || ^19.0",
@@ -92,7 +92,6 @@
9292
"@vitest/browser": "^3.2.2",
9393
"@vitest/coverage-v8": "^3.2.2",
9494
"axe-core": "^4.10.3",
95-
"bootstrap": "5.2.3",
9695
"eslint": "^9.28.0",
9796
"eslint-plugin-import": "^2.31.0",
9897
"eslint-plugin-jsx-a11y": "^6.10.2",

src/Main.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ const Main: FCWithDeps<MainProps, MainDeps> = ({ createNotFound }) => {
9090
className="tw:min-h-full tw:pt-[20px] tw:md:pt-[30px] tw:md:pl-(--aside-menu-width)"
9191
onPointerDown={hideSidebar}
9292
>
93-
<div className="container-xl">
93+
<div className="tw:container tw:mx-auto tw:px-3">
9494
<Routes>
9595
<Route index element={<Navigate replace to="overview" />} />
9696
<Route path="/overview" element={<Overview />} />

src/short-urls/UseExistingIfFoundInfoIcon.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const InfoModal = (props: { open: boolean; onClose: () => void }) => (
1515
<p>
1616
These are the checks performed by Shlink in order to determine if an existing short URL should be returned:
1717
</p>
18-
<ul className="tw:list-disc tw:mb-0">
18+
<ul className="tw:list-disc tw:pl-5">
1919
<li>
2020
When only the long URL is provided: The most recent match will be returned, or a new short URL will be
2121
created

src/short-urls/helpers/QrCodeModal.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { Button, CardModal } from '@shlinkio/shlink-frontend-kit/tailwind';
66
import type { DrawType } from 'qr-code-styling';
77
import type { ChangeEvent, FC } from 'react';
88
import { useCallback, useRef, useState } from 'react';
9+
import { ExternalLink } from 'react-external-link';
910
import type { QrCodeSettings } from '../../settings';
1011
import { defaultQrCodeSettings, useSetting } from '../../settings';
1112
import { ColorInput } from '../../utils/components/ColorInput';
@@ -60,8 +61,13 @@ export const QrCodeModal: FC<QrCodeModalProps> = (
6061
}, [initialQrSettings]);
6162

6263
return (
63-
// TODO Use a link for the header's shortURL as soon as title can be a ReactNode
64-
<CardModal open={isOpen} onClose={onClose} title={`QR code for ${shortUrl}`} size="lg" onClosed={resetOptions}>
64+
<CardModal
65+
size="lg"
66+
open={isOpen}
67+
onClose={onClose}
68+
title={<>QR code for <ExternalLink href={shortUrl} /></>}
69+
onClosed={resetOptions}
70+
>
6571
<div className="tw:flex tw:flex-col-reverse tw:lg:flex-row tw:gap-4">
6672
<div className="tw:grow tw:flex tw:items-center tw:justify-around">
6773
<div className="tw:flex tw:flex-col tw:gap-1 tw:items-center" data-testid="qr-code-container">

src/short-urls/helpers/ShortUrlVisitsCount.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export const ShortUrlVisitsCount = (
4343
</small>
4444
</span>
4545
<Tooltip {...tooltip}>
46-
<ul className="tw:p-0 tw:m-0 tw:flex tw:flex-col tw:gap-y-2">
46+
<ul className="tw:flex tw:flex-col tw:gap-y-2">
4747
{maxVisits && (
4848
<li>
4949
This short URL will not accept more than <b>{formatNumber(maxVisits)}</b> visit{maxVisits === 1 ? '' : 's'}.

src/utils/components/UnstyledButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import type { FC, HTMLProps } from 'react';
44
export const UnstyledButton: FC<Omit<HTMLProps<HTMLButtonElement>, 'type'>> = ({ className, ...rest }) => (
55
<button
66
type="button"
7-
className={clsx('tw:rounded-sm tw:focus-ring', className)}
7+
className={clsx('tw:rounded-sm tw:focus-ring tw:cursor-pointer', className)}
88
{...rest}
99
/>
1010
);

src/visits/VisitsHeader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export const VisitsHeader: FC<VisitsHeaderProps> = ({ visits, shortUrl, children
3535
<small>{title}</small>
3636
</h3>
3737

38-
{children && <div className="tw:md:mt-2">{children}</div>}
38+
{children && <div className="tw:md:mt-3">{children}</div>}
3939
</SimpleCard>
4040
</header>
4141
);

0 commit comments

Comments
 (0)