Skip to content

Commit cc5d5df

Browse files
Optimizely bug fix (#3677)
* country and state fix * optimizely advanced audience targeting reject null id * removing fb fapi changes
1 parent 06e8357 commit cc5d5df

2 files changed

Lines changed: 27 additions & 0 deletions

File tree

  • packages/destination-actions/src/destinations/optimizely-advanced-audience-targeting/syncAudience

packages/destination-actions/src/destinations/optimizely-advanced-audience-targeting/syncAudience/__tests__/index.test.ts

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,18 @@ describe('OptimizelyAdvancedAudienceTargeting.syncAudience', () => {
6464
).resolves.not.toThrowError()
6565
})
6666

67+
it('should reject event when optimizelyUserId is null', async () => {
68+
await expect(
69+
testDestination.testAction('syncAudience', {
70+
event: trackEvent,
71+
useDefaultMappings: true,
72+
mapping: {
73+
optimizelyUserId: null
74+
}
75+
})
76+
).rejects.toThrowError()
77+
})
78+
6779
it('should handle errors response', async () => {
6880
nock('https://function.zaius.app/twilio_segment').post('/batch_sync_audience').reply(400)
6981

@@ -153,6 +165,20 @@ describe('OptimizelyAdvancedAudienceTargeting.syncAudience', () => {
153165
).resolves.not.toThrowError()
154166
})
155167

168+
it('should reject events when optimizelyUserId is null', async () => {
169+
await testDestination.testBatchAction('syncAudience', {
170+
events: identifyEvents,
171+
useDefaultMappings: true,
172+
mapping: {
173+
optimizelyUserId: null
174+
}
175+
})
176+
177+
const multiStatus = testDestination.results[0].multistatus
178+
expect(multiStatus).toBeDefined()
179+
expect(multiStatus?.every((r) => r.status === 400)).toBe(true)
180+
})
181+
156182
it('should handle errors response', async () => {
157183
nock('https://function.zaius.app/twilio_segment').post('/batch_sync_audience').reply(400)
158184

packages/destination-actions/src/destinations/optimizely-advanced-audience-targeting/syncAudience/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ const action: ActionDefinition<Settings, Payload> = {
4444
description: 'The user identifier to sync to the Optimizely Audience',
4545
type: 'string',
4646
required: true,
47+
allowNull: false,
4748
default: {
4849
'@if': {
4950
exists: { '@path': '$.userId' },

0 commit comments

Comments
 (0)