Skip to content

Commit 83a711f

Browse files
authored
Revert "STRATCONN-6441 - [Facebook CAPI] - Append Event functionality and ref…" (#3673)
This reverts commit cbbb5f6.
1 parent 029337b commit 83a711f

55 files changed

Lines changed: 2583 additions & 4190 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/destination-actions/src/destinations/facebook-conversions-api/__tests__/addToCart.test.ts

Lines changed: 11 additions & 61 deletions
Large diffs are not rendered by default.

packages/destination-actions/src/destinations/facebook-conversions-api/__tests__/addToCart2.test.ts

Lines changed: 11 additions & 62 deletions
Large diffs are not rendered by default.

packages/destination-actions/src/destinations/facebook-conversions-api/__tests__/app-data.test.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
import { generateAppData } from '../functions'
2-
import { AnyPayload, GeneratedAppData } from '../types'
1+
import { generate_app_data, AppData, GeneratedAppData } from '../fb-capi-app-data'
32

43
describe('FacebookConversionsApi', () => {
54
describe('AppData', () => {
6-
const sampleAppDataComplete: AnyPayload['app_data_field'] = {
5+
const sampleAppDataComplete: AppData = {
76
use_app_data: true,
87
advertiser_tracking_enabled: true,
98
application_tracking_enabled: true,
@@ -24,7 +23,7 @@ describe('FacebookConversionsApi', () => {
2423
freeStorage: '64',
2524
deviceTimezone: 'America/Los_Angeles'
2625
}
27-
const sampleAppDataIncomplete: AnyPayload['app_data_field'] = {
26+
const sampleAppDataIncomplete: AppData = {
2827
...sampleAppDataComplete
2928
}
3029
delete sampleAppDataIncomplete.timezone
@@ -34,28 +33,28 @@ describe('FacebookConversionsApi', () => {
3433
// app data should always have a length 16 array. Do not change this without first verifying something has changed with facebook.
3534
// A previous issue arose where we sent length 18 arrays and event delivery silently failed.
3635
it('generated app data should always have a length 16 exinfo array', () => {
37-
let appData: GeneratedAppData | undefined = generateAppData(sampleAppDataComplete)
36+
let appData: GeneratedAppData | undefined = generate_app_data(sampleAppDataComplete)
3837
if (appData) {
3938
expect(appData.extinfo.length).toBe(16)
4039
}
4140
expect(appData).toBeDefined()
4241

43-
appData = generateAppData(sampleAppDataIncomplete)
42+
appData = generate_app_data(sampleAppDataIncomplete)
4443
if (appData) {
4544
expect(appData.extinfo.length).toBe(16)
4645
}
4746
expect(appData).toBeDefined()
4847
})
4948

5049
it('generated app data should be undefined if use_app_data is false', () => {
51-
const appData = generateAppData({
50+
const appData = generate_app_data({
5251
use_app_data: false
5352
})
5453
expect(appData).toBeUndefined()
5554
})
5655

5756
it('generated app data should include empty strings if fields are missing from extinfo', () => {
58-
const appData = generateAppData(sampleAppDataIncomplete)
57+
const appData = generate_app_data(sampleAppDataIncomplete)
5958
if (appData) {
6059
expect(appData.advertiser_tracking_enabled).toBe(1)
6160
expect(appData.application_tracking_enabled).toBe(1)

0 commit comments

Comments
 (0)