added dynamic identifiers (#3704)

* added dynamic identifiers

* check invalid identifiers

* fix typescript issue

* fix hyperengage test

* deepreview fixes

* added types

Author: monutwilio

packages/destination-actions/src/destinations/hyperengage/__tests__/validateInput.test.ts

@@ -81,7 +81,7 @@ describe('validateInput', () => {
       expect(payload.traits.industry).toEqual(fakeGroupData.industry)
       expect(payload.traits.website).toEqual(fakeGroupData.website)
       expect(payload.traits).toHaveProperty('required')
-      expect(payload.local_tz_offset).toEqual(60)
+      expect(payload.local_tz_offset).toEqual(120)
     })
   })
 

packages/destination-actions/src/destinations/memora-internal/upsertProfile.types.ts

@@ -14,22 +14,15 @@ export interface Payload {
    */
   memora_store: string
   /**
-   * Profile identifiers (email and/or phone). At least one identifier is required. These identifiers are stored in the Contact trait group.
+   * Profile identifiers from all trait groups. At runtime, each event must contain at least one identifier with a non-null value, and at least two total non-null fields across identifiers and traits combined. Events with sparse data (e.g., only one identifier present) will be rejected. These fields are dynamically loaded from the selected Memora Store. When manually entering keys, use the format "TraitGroupName.$.traitName" (e.g., "Contact.$.email", "Contact.$.phone").
    */
   profile_identifiers: {
-    /**
-     * User email address
-     */
-    email?: string
-    /**
-     * User phone number
-     */
-    phone?: string
+    [k: string]: unknown
   }
   /**
-   * Traits for the profile from all trait groups. At least one trait is required. These fields are dynamically loaded from the selected Memora Store. When manually entering keys, use the format "TraitGroupName.$.traitName" (e.g., "Contact.$.firstName", "PurchaseHistory.$.lastPurchaseDate").
+   * Traits for the profile from all trait groups. While this field is optional in the mapping configuration, at runtime each event must have at least two total non-null fields across identifiers and traits combined. If you map only one identifier, you must also map at least one trait that will have a value for your events. These fields are dynamically loaded from the selected Memora Store. When manually entering keys, use the format "TraitGroupName.$.traitName" (e.g., "Contact.$.firstName", "PurchaseHistory.$.lastPurchaseDate").
    */
-  profile_traits: {
+  profile_traits?: {
     [k: string]: unknown
   }
 }

packages/destination-actions/src/destinations/memora/__tests__/snapshot.test.ts

@@ -36,7 +36,7 @@ describe(`Testing snapshot for ${destinationSlug} destination:`, () => {
         ...event.properties,
         memora_store: 'test-store-id',
         profile_identifiers: {
-          email: '[email protected]'
+          'Contact.$.email': '[email protected]'
         },
         profile_traits: {
           'Contact.$.firstName': 'Test'
@@ -81,7 +81,7 @@ describe(`Testing snapshot for ${destinationSlug} destination:`, () => {
         ...event.properties,
         memora_store: 'test-store-id',
         profile_identifiers: {
-          email: '[email protected]'
+          'Contact.$.email': '[email protected]'
         },
         profile_traits: {
           'Contact.$.firstName': 'Test',