fix: resolving comments (#10)

Author: satyamMIPL

packages/destination-actions/src/destinations/moengage/__tests__/__snapshots__/snapshot.test.ts.snap

@@ -70,7 +70,6 @@ Object {
     "os": Object {},
   },
   "event": "E@t!q#n(^u",
-  "properties": Object {},
   "type": "E@t!q#n(^u",
   "update_existing_only": false,
 }

packages/destination-actions/src/destinations/moengage/trackEvent/__tests__/__snapshots__/snapshot.test.ts.snap

@@ -34,7 +34,6 @@ Object {
     "os": Object {},
   },
   "event": "[3(wtAyZqr",
-  "properties": Object {},
   "type": "[3(wtAyZqr",
   "update_existing_only": false,
 }

packages/destination-actions/src/destinations/moengage/trackEvent/__tests__/index.test.ts

@@ -125,8 +125,8 @@ describe('ActionsMoengage.trackEvent', () => {
 
     nock(`${endpoint}`).post(`/v1/integrations/segment?appId=${api_id}`).reply(200, {})
 
-    try {
-      await testDestination.testAction('trackEvent', {
+    await expect(
+      testDestination.testAction('trackEvent', {
         event,
         useDefaultMappings: true,
         settings: {
@@ -135,8 +135,6 @@ describe('ActionsMoengage.trackEvent', () => {
           region
         }
       })
-    } catch (e) {
-      expect(e.message).toBe("The root value is missing the required field 'event'.")
-    }
+    ).rejects.toThrow("The root value is missing the required field 'event'.")
   })
 })

packages/destination-actions/src/destinations/moengage/trackEvent/index.ts

@@ -106,9 +106,12 @@ const action: ActionDefinition<Settings, Payload> = {
       throw new IntegrationError('Missing API ID or API KEY', 'Missing required field', 400)
     }
 
-    const properties = payload.properties ? { ...payload.properties } : {}
+    let properties = payload.properties
     if (payload.project_name) {
-      properties.moe_project_name = payload.project_name
+      properties = {
+        ...(payload.properties ?? {}),
+        moe_project_name: payload.project_name
+      }
     }
 
     const event = {