Add bin-support for templates, updated test-support for full plugin rather than visitor fn

Author: simonihmig

src/bin-support.js

@@ -1,8 +1,9 @@
 'use strict';
 
-const DEFAULT_EXTENSIONS = 'js,ts';
+const DEFAULT_JS_EXTENSIONS = 'js,ts';
+const DEFAULT_TEMPLATE_EXTENSIONS = 'hbs';
 
-async function runTransform(binRoot, transformName, args, extensions = DEFAULT_EXTENSIONS) {
+async function runJsTransform(binRoot, transformName, args, extensions = DEFAULT_JS_EXTENSIONS) {
   const globby = require('globby');
   const execa = require('execa');
   const chalk = require('chalk');
@@ -37,6 +38,55 @@ async function runTransform(binRoot, transformName, args, extensions = DEFAULT_E
   }
 }
 
+async function runTemplateTransform(
+  binRoot,
+  transformName,
+  args,
+  extensions = DEFAULT_TEMPLATE_EXTENSIONS
+) {
+  const globby = require('globby');
+  const execa = require('execa');
+  const chalk = require('chalk');
+  const path = require('path');
+  const { parseTransformArgs } = require('./options-support');
+
+  let { paths, options } = parseTransformArgs(args);
+
+  try {
+    let foundPaths = await globby(paths, {
+      expandDirectories: { extensions: extensions.split(',') },
+    });
+    let transformPath = path.join(binRoot, '..', 'transforms', transformName, 'index.js');
+
+    let templateRecastPkg = require('ember-template-recast/package');
+    let templateRecastPath = path.dirname(require.resolve('ember-template-recast/package'));
+    let binPath = path.join(templateRecastPath, templateRecastPkg.bin);
+
+    let binOptions = ['-t', transformPath, ...foundPaths];
+
+    return execa(binPath, binOptions, {
+      stdio: 'inherit',
+      env: {
+        CODEMOD_CLI_ARGS: JSON.stringify(options),
+      },
+    });
+  } catch (error) {
+    console.error(chalk.red(error.stack)); // eslint-disable-line no-console
+    process.exitCode = 1;
+
+    throw error;
+  }
+}
+
+async function runTransform(binRoot, transformName, args, extensions, type = 'jscodeshift') {
+  switch (type) {
+    case 'jscodeshift':
+      return runJsTransform(binRoot, transformName, args, extensions);
+    case 'template':
+      return runTemplateTransform(binRoot, transformName, args, extensions);
+  }
+}
+
 module.exports = {
   runTransform,
 };

src/test-support/template.js

@@ -1,24 +1,35 @@
 'use strict';
 
-/* global expect, it, describe, beforeEach, afterEach */
+/* global expect, it, describe */
 
 const fs = require('fs-extra');
 const path = require('path');
 const globby = require('globby');
 const { transformDetails } = require('./utils');
+const { transform, parse } = require('ember-template-recast');
 
-function runTemplateTest(transformFn, input, expectedOutput) {
-  const { transform } = require('ember-template-recast');
-
-  let { code } = transform(input, transformFn);
+function runTemplateTest(plugin, { path, source }, expectedOutput) {
+  const code = plugin(
+    {
+      path,
+      source,
+    },
+    {
+      parse,
+      visit(ast, callback) {
+        const results = transform(ast, callback);
+        return results && results.code;
+      },
+    }
+  );
 
   expect((code || '').trim()).toEqual(expectedOutput.trim());
 }
 
 module.exports = function templateTest(options) {
   let details = transformDetails(options);
 
-  let transform = require(details.transformPath);
+  let plugin = require(details.transformPath);
 
   describe(details.name, function() {
     globby
@@ -30,32 +41,23 @@ module.exports = function templateTest(options) {
       .forEach(filename => {
         let extension = path.extname(filename);
         let testName = filename.replace(`.input${extension}`, '');
+        let testInputPath = path.join(details.fixtureDir, `${testName}${extension}`);
         let inputPath = path.join(details.fixtureDir, `${testName}.input${extension}`);
         let outputPath = path.join(details.fixtureDir, `${testName}.output${extension}`);
-        let optionsPath = path.join(details.fixtureDir, `${testName}.options.json`);
-        let options = fs.pathExistsSync(optionsPath) ? fs.readFileSync(optionsPath) : '{}';
 
         describe(testName, function() {
-          beforeEach(function() {
-            process.env.CODEMOD_CLI_ARGS = options;
-          });
-
-          afterEach(function() {
-            process.env.CODEMOD_CLI_ARGS = '';
-          });
-
           it('transforms correctly', function() {
             runTemplateTest(
-              transform,
-              fs.readFileSync(inputPath, 'utf8'),
+              plugin,
+              { path: testInputPath, source: fs.readFileSync(inputPath, 'utf8') },
               fs.readFileSync(outputPath, 'utf8')
             );
           });
 
           it('is idempotent', function() {
             runTemplateTest(
-              transform,
-              fs.readFileSync(outputPath, 'utf8'),
+              plugin,
+              { path: testInputPath, source: fs.readFileSync(inputPath, 'utf8') },
               fs.readFileSync(outputPath, 'utf8')
             );
           });