Merge pull request #83 from simonihmig/drop-node-8

Author: rwjblue

.github/workflows/ci.yml

@@ -32,7 +32,7 @@ jobs:
 
     strategy:
       matrix:
-        node: ['^8.12.0', '10', '12']
+        node: ['10', '12', '13']
         os: [ubuntu-latest, macOS-latest]
 
     steps:

bin/cli.js

@@ -15,7 +15,7 @@ const pkgUp = require('pkg-up');
 function insideProject() {
   let nearestPackagePath = pkgUp.sync();
 
-  if (nearestPackagePath === null) {
+  if (!nearestPackagePath) {
     return false;
   }
 

package.json

@@ -65,7 +65,7 @@
     "walk-sync": "^2.0.2"
   },
   "engines": {
-    "node": "8.* || 10.* || >= 12"
+    "node": "10.* || >= 12"
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org"

tests/cli-test.js

@@ -12,7 +12,7 @@ const ROOT = process.cwd();
 QUnit.module('codemod-cli', function(hooks) {
   let codemodProject;
 
-  function setupProject(hooks) {
+  function setupProject(hooks, installDeps = false) {
     let sharedProject;
 
     hooks.before(async function() {
@@ -24,13 +24,22 @@ QUnit.module('codemod-cli', function(hooks) {
       process.chdir(ROOT);
     });
 
-    hooks.beforeEach(function() {
+    hooks.beforeEach(async function() {
       codemodProject.copy(sharedProject.path('test-project'));
 
+      const jestPath = `${codemodProject.path()}/node_modules/jest`;
+      const codemodCliPath = `${codemodProject.path()}/node_modules/codemod-cli`;
+
+      if (installDeps) {
+        await execa('yarn');
+        fs.removeSync(jestPath);
+        fs.removeSync(codemodCliPath);
+      }
+
       // setup required dependencies in the project
       fs.ensureDirSync(`${codemodProject.path()}/node_modules`);
-      fs.symlinkSync(`${ROOT}/node_modules/jest`, `${codemodProject.path()}/node_modules/jest`);
-      fs.symlinkSync(PROJECT_ROOT, `${codemodProject.path()}/node_modules/codemod-cli`);
+      fs.symlinkSync(`${ROOT}/node_modules/jest`, jestPath);
+      fs.symlinkSync(PROJECT_ROOT, codemodCliPath);
     });
   }
 
@@ -72,11 +81,7 @@ QUnit.module('codemod-cli', function(hooks) {
   });
 
   QUnit.module('linting', function(hooks) {
-    setupProject(hooks);
-
-    hooks.beforeEach(async function() {
-      await execa('yarn');
-    });
+    setupProject(hooks, true);
 
     QUnit.test('should pass for a basic project', async function(assert) {
       let result = await execa('yarn', ['lint']);