Address PR feedback

Author: simonihmig

commands/local/generate/codemod.js

@@ -180,5 +180,7 @@ module.exports.handler = function handler(options) {
       return jsHandler(options);
     case 'hbs':
       return hbsHandler(options);
+    default:
+      throw new Error(`Unknown type: "${options.type}"`);
   }
 };

src/bin-support.js

@@ -57,15 +57,11 @@ async function runTemplateTransform(
       expandDirectories: { extensions: extensions.split(',') },
     });
     let transformPath = path.join(binRoot, '..', 'transforms', transformName, 'index.js');
-
-    let templateRecastPkg = require('ember-template-recast/package');
-    let templateRecastPath = path.dirname(require.resolve('ember-template-recast/package'));
-    let binPath = path.join(templateRecastPath, templateRecastPkg.bin);
-
     let binOptions = ['-t', transformPath, ...foundPaths];
 
-    return execa(binPath, binOptions, {
+    return execa('ember-template-recast', binOptions, {
       stdio: 'inherit',
+      preferLocal: true,
       env: {
         CODEMOD_CLI_ARGS: JSON.stringify(options),
       },
@@ -84,6 +80,8 @@ async function runTransform(binRoot, transformName, args, extensions, type = 'js
       return runJsTransform(binRoot, transformName, args, extensions);
     case 'template':
       return runTemplateTransform(binRoot, transformName, args, extensions);
+    default:
+      throw new Error(`Unknown type passed to runTransform: "${type}"`);
   }
 }
 

src/test-support.js

@@ -9,6 +9,8 @@ function runTransformTest(options) {
       return jscodeshiftTest(options);
     case 'template':
       return templateTest(options);
+    default:
+      throw new Error(`Unknown type passed to runTransformTest: "${options.type}"`);
   }
 }
 

src/test-support/template.js

@@ -8,10 +8,10 @@ const globby = require('globby');
 const { transformDetails } = require('./utils');
 const { transform, parse } = require('ember-template-recast');
 
-function runTemplateTest(plugin, { path, source }, expectedOutput) {
+function runTemplateTest(plugin, { path: pluginPath, source }, expectedOutput) {
   const code = plugin(
     {
-      path,
+      path: pluginPath,
       source,
     },
     {
@@ -23,7 +23,7 @@ function runTemplateTest(plugin, { path, source }, expectedOutput) {
     }
   );
 
-  expect((code || '').trim()).toEqual(expectedOutput.trim());
+  expect(code || '').toEqual(expectedOutput);
 }
 
 module.exports = function templateTest(options) {
@@ -57,7 +57,7 @@ module.exports = function templateTest(options) {
           it('is idempotent', function() {
             runTemplateTest(
               plugin,
-              { path: testInputPath, source: fs.readFileSync(inputPath, 'utf8') },
+              { path: testInputPath, source: fs.readFileSync(outputPath, 'utf8') },
               fs.readFileSync(outputPath, 'utf8')
             );
           });