Allow runTransform to accept path to transform to run.

Author: Robert Jackson

src/bin-support.js

@@ -2,21 +2,19 @@
 
 const DEFAULT_JS_EXTENSIONS = 'js,ts';
 
-async function runJsTransform(root, transformName, args, extensions = DEFAULT_JS_EXTENSIONS) {
+async function runJsTransform(transformPath, args, extensions = DEFAULT_JS_EXTENSIONS) {
   const globby = require('globby');
   const execa = require('execa');
   const chalk = require('chalk');
   const path = require('path');
   const { parseTransformArgs } = require('./options-support');
-  const { getTransformPath } = require('./transform-support');
 
   let { paths, options, transformerOptions } = parseTransformArgs(args);
 
   try {
     let foundPaths = await globby(paths, {
       expandDirectories: { extensions: extensions.split(',') },
     });
-    let transformPath = getTransformPath(root, transformName);
 
     let jscodeshiftPkg = require('jscodeshift/package');
     let jscodeshiftPath = path.dirname(require.resolve('jscodeshift/package'));
@@ -45,17 +43,15 @@ async function runJsTransform(root, transformName, args, extensions = DEFAULT_JS
   }
 }
 
-async function runTemplateTransform(root, transformName, args) {
+async function runTemplateTransform(transformPath, args) {
   const execa = require('execa');
   const chalk = require('chalk');
   const path = require('path');
   const { parseTransformArgs } = require('./options-support');
-  const { getTransformPath } = require('./transform-support');
 
   let { paths, options } = parseTransformArgs(args);
 
   try {
-    let transformPath = getTransformPath(root, transformName);
     let binOptions = ['-t', transformPath, ...paths];
     let templateRecastDir = path.dirname(require.resolve('ember-template-recast/package.json'));
     let templateRecastPkg = require('ember-template-recast/package');
@@ -85,9 +81,9 @@ async function runTransform(binRoot, transformName, args, extensions) {
 
   switch (type) {
     case 'js':
-      return runJsTransform(root, transformName, args, extensions);
+      return runJsTransform(transformPath, args, extensions);
     case 'hbs':
-      return runTemplateTransform(root, transformName, args);
+      return runTemplateTransform(transformPath, args);
     default:
       throw new Error(`Unknown type passed to runTransform: "${type}"`);
   }

src/transform-support.js

@@ -3,6 +3,11 @@
 function getTransformPath(root, transformName) {
   const path = require('path');
 
+  // transformName **IS** a valid path, no need to resolve manually
+  if (transformName.startsWith('.') || transformName.startsWith('/')) {
+    return transformName;
+  }
+
   return require.resolve(path.join(root, 'transforms', transformName));
 }
 

tests/cli-test.js

@@ -444,6 +444,25 @@ QUnit.module('codemod-cli', function (hooks) {
         },
       });
     });
+
+    QUnit.test('works with custom codemod directory', async function (assert) {
+      userProject.write({
+        foo: { 'something.js': 'let blah = bar', 'other.js': 'let blah = bar' },
+      });
+
+      await execa(EXECUTABLE_PATH, ['generate', 'codemod', 'secondary', '--codemod-dir', 'other-dir'], {
+        cwd: codemodProject.path(),
+      });
+
+      await execa(codemodProject.path('bin/cli.js'), [codemodProject.path('./other-dir/secondary/index.js'), 'foo/*thing.js']);
+
+      assert.deepEqual(userProject.read(), {
+        foo: {
+          'something.js': 'let halb = rab',
+          'other.js': 'let blah = bar',
+        },
+      });
+    });
   });
 
   QUnit.module('programmatic API', function (hooks) {