diff --git a/scripts/airtable-get-data.R b/scripts/airtable-get-data.R index cb005189b..00bd33995 100644 --- a/scripts/airtable-get-data.R +++ b/scripts/airtable-get-data.R @@ -24,13 +24,13 @@ at_guest <- airtabler::airtable(base = "app8dssb6a7PG6Vwj", table = "guest-editors") -editor_index_all <- purrr::map_lgl(reviewers$editor, ~!is.null(.)) +editor_index_all <- purrr::map_lgl(reviewers$editor, ~!is.null(.) && !anyNA(.)) editors_all <- reviewers[which(editor_index_all), c("name", "github", "Affiliation", "editor")] editors_all <- editors_all [which(!editors_all$name == eic_name), ] last_names <- humaniformat::last_name(trimws(editors_all$name)) editors_all <- editors_all[order(last_names), ] -editors_past <- editors_all[grep("Emeritus", editors_all$editor), ] +editors_past <- editors_all[grep("Emeritus|On\\sLeave", editors_all$editor), ] editors <- editors_all[which(!editors_all$name %in% editors_past$name), ] guest_editors <- at_guest$`guest-editors`$select_all() diff --git a/softwarereview_editor_management.Rmd b/softwarereview_editor_management.Rmd index 3f77aefd7..a926d9dca 100644 --- a/softwarereview_editor_management.Rmd +++ b/softwarereview_editor_management.Rmd @@ -66,6 +66,8 @@ Best, - Invite them to the AirTable database of software review (linked in the description of the editors-only channel on Slack). Ensure invitation is "Read only". +- Update the "editor" field in the Airtable "reviewers-prod" table (this is used to identify and list current editors within this _Dev Guide_). + - Invite them to the private "editors-only" channel in rOpenSci's Slack workspace (and to the Slack workspace in general if they're not yet there). - Once they're in the "editors-only" channel, post a welcome message pinging all editors. @@ -87,6 +89,8 @@ Best, - Click "Share" button on top right, and then "People with access" - Click checkbox on left on editor to be removed, and "Remove 1 collaborator". +- Change their "editor" label in the Airtable "reviewers-prod" data to "Emeritus" + - The (past-)editors lists in both the [dev\_guide chapter introducing software review](https://github.com/ropensci/dev_guide/blob/main/softwarereview_intro.Rmd) and the [software-review README](https://github.com/ropensci/software-review/blob/main/README.Rmd) are automatically populated from the AirTable data. Updates are run daily, so check a day after AirTable updates to ensure both have been updated.