added value type check for old flexbox props

Robin Frischmann · Robin Frischmann · commit 937eba1dd775 · 2016-09-16T09:46:20.000+02:00
diff --git a/modules/plugins/flexboxOld.js b/modules/plugins/flexboxOld.js
@@ -34,7 +34,7 @@ export default function flexboxOld({ property, value, styles, browserInfo: { bro
     if (!keepUnprefixed && !Array.isArray(styles[property])) {
       delete styles[property]
     }
-    if (property === 'flexDirection') {
+    if (property === 'flexDirection' && typeof value === 'string') {
       return {
         WebkitBoxOrient: value.indexOf('column') > -1 ? 'vertical' : 'horizontal',
         WebkitBoxDirection: value.indexOf('reverse') > -1 ? 'reverse' : 'normal'
diff --git a/modules/static/plugins/flexboxOld.js b/modules/static/plugins/flexboxOld.js
@@ -14,7 +14,7 @@ const alternativeProps = {
 }
 
 export default function flexboxOld(property, value) {
-  if (property === 'flexDirection') {
+  if (property === 'flexDirection' && typeof value === 'string') {
     return {
       WebkitBoxOrient: value.indexOf('column') > -1 ? 'vertical' : 'horizontal',
       WebkitBoxDirection: value.indexOf('reverse') > -1 ? 'reverse' : 'normal'

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ export default function flexboxOld({ property, value, styles, browserInfo: { bro`
`34`	`34`	`if (!keepUnprefixed && !Array.isArray(styles[property])) {`
`35`	`35`	`delete styles[property]`
`36`	`36`	`}`
`37`		`- if (property === 'flexDirection') {`
	`37`	`+ if (property === 'flexDirection' && typeof value === 'string') {`
`38`	`38`	`return {`
`39`	`39`	`WebkitBoxOrient: value.indexOf('column') > -1 ? 'vertical' : 'horizontal',`
`40`	`40`	`WebkitBoxDirection: value.indexOf('reverse') > -1 ? 'reverse' : 'normal'`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ const alternativeProps = {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`export default function flexboxOld(property, value) {`
`17`		`- if (property === 'flexDirection') {`
	`17`	`+ if (property === 'flexDirection' && typeof value === 'string') {`
`18`	`18`	`return {`
`19`	`19`	`WebkitBoxOrient: value.indexOf('column') > -1 ? 'vertical' : 'horizontal',`
`20`	`20`	`WebkitBoxDirection: value.indexOf('reverse') > -1 ? 'reverse' : 'normal'`